From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anatolij Gustschin Date: Thu, 30 Oct 2014 23:16:22 +0100 Subject: [U-Boot] [PATCH v2] tools/kwbimage: Fix compilation warning In-Reply-To: <1414492344-19055-1-git-send-email-sr@denx.de> References: <1414492344-19055-1-git-send-email-sr@denx.de> Message-ID: <20141030231622.66074ace@crub> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, 28 Oct 2014 11:32:24 +0100 Stefan Roese wrote: > This patch fixes a compilation warning of kwbimage.c: > > tools/kwbimage.c: In function ?kwbimage_set_header?: > tools/kwbimage.c:784:8: warning: ?headersz? may be used uninitialized in this function [-Wmaybe-uninitialized] > memcpy(ptr, image, headersz); > ^ > Instead of using multiple if statements, use a switch statement with > a default entry. And return with error if an unsupported version > is configured in the cfg file. > > Signed-off-by: Stefan Roese > --- > v2: > - Change error message so that it really makes sense (unsupported > version instead of no version) > - Change this also in the commit text > - Small change (s/is/if) > > tools/kwbimage.c | 23 +++++++++++++++++------ > 1 file changed, 17 insertions(+), 6 deletions(-) Applied to u-boot-staging. Thanks! Anatolij