* [U-Boot] [PATCH] twl4030: TWL4030 VMMC2 3.2V enable on MMC init
@ 2014-10-28 14:05 Paul Kocialkowski
2014-10-28 15:47 ` Igor Grinberg
2014-10-28 17:14 ` [U-Boot] [PATCH v2] twl4030: " Paul Kocialkowski
0 siblings, 2 replies; 6+ messages in thread
From: Paul Kocialkowski @ 2014-10-28 14:05 UTC (permalink / raw)
To: u-boot
Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
---
drivers/power/twl4030.c | 6 ++++++
include/twl4030.h | 2 ++
2 files changed, 8 insertions(+)
diff --git a/drivers/power/twl4030.c b/drivers/power/twl4030.c
index 3e50310..e578ae6 100644
--- a/drivers/power/twl4030.c
+++ b/drivers/power/twl4030.c
@@ -98,4 +98,10 @@ void twl4030_power_mmc_init(void)
TWL4030_PM_RECEIVER_VMMC1_VSEL_32,
TWL4030_PM_RECEIVER_VMMC1_DEV_GRP,
TWL4030_PM_RECEIVER_DEV_GRP_P1);
+
+ /* Set VMMC2 to 3.15 Volts */
+ twl4030_pmrecv_vsel_cfg(TWL4030_PM_RECEIVER_VMMC2_DEDICATED,
+ TWL4030_PM_RECEIVER_VMMC2_VSEL_32,
+ TWL4030_PM_RECEIVER_VMMC2_DEV_GRP,
+ TWL4030_PM_RECEIVER_DEV_GRP_P1);
}
diff --git a/include/twl4030.h b/include/twl4030.h
index 093c61d..18795a6 100644
--- a/include/twl4030.h
+++ b/include/twl4030.h
@@ -395,6 +395,8 @@
#define TWL4030_PM_RECEIVER_VDAC_VSEL_18 0x03
#define TWL4030_PM_RECEIVER_VMMC1_VSEL_30 0x02
#define TWL4030_PM_RECEIVER_VMMC1_VSEL_32 0x03
+#define TWL4030_PM_RECEIVER_VMMC2_VSEL_30 0x0B
+#define TWL4030_PM_RECEIVER_VMMC2_VSEL_32 0x0C
#define TWL4030_PM_RECEIVER_VSIM_VSEL_18 0x03
/* Device Selection in PM Receiver Module */
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] twl4030: TWL4030 VMMC2 3.2V enable on MMC init
2014-10-28 14:05 [U-Boot] [PATCH] twl4030: TWL4030 VMMC2 3.2V enable on MMC init Paul Kocialkowski
@ 2014-10-28 15:47 ` Igor Grinberg
2014-10-28 16:04 ` Paul Kocialkowski
2014-10-28 17:14 ` [U-Boot] [PATCH v2] twl4030: " Paul Kocialkowski
1 sibling, 1 reply; 6+ messages in thread
From: Igor Grinberg @ 2014-10-28 15:47 UTC (permalink / raw)
To: u-boot
Hi Paul,
On 10/28/14 16:05, Paul Kocialkowski wrote:
> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
Usually, it is a good practice to add a commit message
(and not just the subject).
It will be highly appreciated if you can provide also an
explanation (in the commit message) of what and why it is done.
Thanks!
> ---
> drivers/power/twl4030.c | 6 ++++++
> include/twl4030.h | 2 ++
> 2 files changed, 8 insertions(+)
>
> diff --git a/drivers/power/twl4030.c b/drivers/power/twl4030.c
> index 3e50310..e578ae6 100644
> --- a/drivers/power/twl4030.c
> +++ b/drivers/power/twl4030.c
> @@ -98,4 +98,10 @@ void twl4030_power_mmc_init(void)
> TWL4030_PM_RECEIVER_VMMC1_VSEL_32,
> TWL4030_PM_RECEIVER_VMMC1_DEV_GRP,
> TWL4030_PM_RECEIVER_DEV_GRP_P1);
> +
> + /* Set VMMC2 to 3.15 Volts */
> + twl4030_pmrecv_vsel_cfg(TWL4030_PM_RECEIVER_VMMC2_DEDICATED,
> + TWL4030_PM_RECEIVER_VMMC2_VSEL_32,
> + TWL4030_PM_RECEIVER_VMMC2_DEV_GRP,
> + TWL4030_PM_RECEIVER_DEV_GRP_P1);
> }
> diff --git a/include/twl4030.h b/include/twl4030.h
> index 093c61d..18795a6 100644
> --- a/include/twl4030.h
> +++ b/include/twl4030.h
> @@ -395,6 +395,8 @@
> #define TWL4030_PM_RECEIVER_VDAC_VSEL_18 0x03
> #define TWL4030_PM_RECEIVER_VMMC1_VSEL_30 0x02
> #define TWL4030_PM_RECEIVER_VMMC1_VSEL_32 0x03
> +#define TWL4030_PM_RECEIVER_VMMC2_VSEL_30 0x0B
> +#define TWL4030_PM_RECEIVER_VMMC2_VSEL_32 0x0C
> #define TWL4030_PM_RECEIVER_VSIM_VSEL_18 0x03
>
> /* Device Selection in PM Receiver Module */
>
--
Regards,
Igor.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] twl4030: TWL4030 VMMC2 3.2V enable on MMC init
2014-10-28 15:47 ` Igor Grinberg
@ 2014-10-28 16:04 ` Paul Kocialkowski
0 siblings, 0 replies; 6+ messages in thread
From: Paul Kocialkowski @ 2014-10-28 16:04 UTC (permalink / raw)
To: u-boot
> Usually, it is a good practice to add a commit message
> (and not just the subject).
>
> It will be highly appreciated if you can provide also an
> explanation (in the commit message) of what and why it is done.
Well, to be honest, I thought it was all self explanatory, but maybe a
bit more context is required. I didn't notice I wrote twl4030 twice, so
I'll probably make a v2, including a description.
Thanks!
> > ---
> > drivers/power/twl4030.c | 6 ++++++
> > include/twl4030.h | 2 ++
> > 2 files changed, 8 insertions(+)
> >
> > diff --git a/drivers/power/twl4030.c b/drivers/power/twl4030.c
> > index 3e50310..e578ae6 100644
> > --- a/drivers/power/twl4030.c
> > +++ b/drivers/power/twl4030.c
> > @@ -98,4 +98,10 @@ void twl4030_power_mmc_init(void)
> > TWL4030_PM_RECEIVER_VMMC1_VSEL_32,
> > TWL4030_PM_RECEIVER_VMMC1_DEV_GRP,
> > TWL4030_PM_RECEIVER_DEV_GRP_P1);
> > +
> > + /* Set VMMC2 to 3.15 Volts */
> > + twl4030_pmrecv_vsel_cfg(TWL4030_PM_RECEIVER_VMMC2_DEDICATED,
> > + TWL4030_PM_RECEIVER_VMMC2_VSEL_32,
> > + TWL4030_PM_RECEIVER_VMMC2_DEV_GRP,
> > + TWL4030_PM_RECEIVER_DEV_GRP_P1);
> > }
> > diff --git a/include/twl4030.h b/include/twl4030.h
> > index 093c61d..18795a6 100644
> > --- a/include/twl4030.h
> > +++ b/include/twl4030.h
> > @@ -395,6 +395,8 @@
> > #define TWL4030_PM_RECEIVER_VDAC_VSEL_18 0x03
> > #define TWL4030_PM_RECEIVER_VMMC1_VSEL_30 0x02
> > #define TWL4030_PM_RECEIVER_VMMC1_VSEL_32 0x03
> > +#define TWL4030_PM_RECEIVER_VMMC2_VSEL_30 0x0B
> > +#define TWL4030_PM_RECEIVER_VMMC2_VSEL_32 0x0C
> > #define TWL4030_PM_RECEIVER_VSIM_VSEL_18 0x03
> >
> > /* Device Selection in PM Receiver Module */
> >
--
Paul Kocialkowski, Replicant developer
Replicant is a fully free Android distribution
Website: http://www.replicant.us/
Wiki/Tracker: http://redmine.replicant.us/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141028/3a00d9b9/attachment.pgp>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH v2] twl4030: VMMC2 3.2V enable on MMC init
2014-10-28 14:05 [U-Boot] [PATCH] twl4030: TWL4030 VMMC2 3.2V enable on MMC init Paul Kocialkowski
2014-10-28 15:47 ` Igor Grinberg
@ 2014-10-28 17:14 ` Paul Kocialkowski
2014-10-30 15:22 ` Pantelis Antoniou
2014-10-30 23:35 ` Anatolij Gustschin
1 sibling, 2 replies; 6+ messages in thread
From: Paul Kocialkowski @ 2014-10-28 17:14 UTC (permalink / raw)
To: u-boot
This enables the VMMC2 LDO, which powers the MMC2 device.
When the device starts from MMC2, this has already been enabled by the BootROM,
but when starting from peripheral boot (USB, UART), it is not the case.
Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
---
drivers/power/twl4030.c | 6 ++++++
include/twl4030.h | 2 ++
2 files changed, 8 insertions(+)
diff --git a/drivers/power/twl4030.c b/drivers/power/twl4030.c
index 3e50310..e578ae6 100644
--- a/drivers/power/twl4030.c
+++ b/drivers/power/twl4030.c
@@ -98,4 +98,10 @@ void twl4030_power_mmc_init(void)
TWL4030_PM_RECEIVER_VMMC1_VSEL_32,
TWL4030_PM_RECEIVER_VMMC1_DEV_GRP,
TWL4030_PM_RECEIVER_DEV_GRP_P1);
+
+ /* Set VMMC2 to 3.15 Volts */
+ twl4030_pmrecv_vsel_cfg(TWL4030_PM_RECEIVER_VMMC2_DEDICATED,
+ TWL4030_PM_RECEIVER_VMMC2_VSEL_32,
+ TWL4030_PM_RECEIVER_VMMC2_DEV_GRP,
+ TWL4030_PM_RECEIVER_DEV_GRP_P1);
}
diff --git a/include/twl4030.h b/include/twl4030.h
index 093c61d..18795a6 100644
--- a/include/twl4030.h
+++ b/include/twl4030.h
@@ -395,6 +395,8 @@
#define TWL4030_PM_RECEIVER_VDAC_VSEL_18 0x03
#define TWL4030_PM_RECEIVER_VMMC1_VSEL_30 0x02
#define TWL4030_PM_RECEIVER_VMMC1_VSEL_32 0x03
+#define TWL4030_PM_RECEIVER_VMMC2_VSEL_30 0x0B
+#define TWL4030_PM_RECEIVER_VMMC2_VSEL_32 0x0C
#define TWL4030_PM_RECEIVER_VSIM_VSEL_18 0x03
/* Device Selection in PM Receiver Module */
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH v2] twl4030: VMMC2 3.2V enable on MMC init
2014-10-28 17:14 ` [U-Boot] [PATCH v2] twl4030: " Paul Kocialkowski
@ 2014-10-30 15:22 ` Pantelis Antoniou
2014-10-30 23:35 ` Anatolij Gustschin
1 sibling, 0 replies; 6+ messages in thread
From: Pantelis Antoniou @ 2014-10-30 15:22 UTC (permalink / raw)
To: u-boot
Hi Paul,
> On Oct 28, 2014, at 19:14 , Paul Kocialkowski <contact@paulk.fr> wrote:
>
> This enables the VMMC2 LDO, which powers the MMC2 device.
> When the device starts from MMC2, this has already been enabled by the BootROM,
> but when starting from peripheral boot (USB, UART), it is not the case.
>
> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> ---
> drivers/power/twl4030.c | 6 ++++++
> include/twl4030.h | 2 ++
> 2 files changed, 8 insertions(+)
>
> diff --git a/drivers/power/twl4030.c b/drivers/power/twl4030.c
> index 3e50310..e578ae6 100644
> --- a/drivers/power/twl4030.c
> +++ b/drivers/power/twl4030.c
> @@ -98,4 +98,10 @@ void twl4030_power_mmc_init(void)
> TWL4030_PM_RECEIVER_VMMC1_VSEL_32,
> TWL4030_PM_RECEIVER_VMMC1_DEV_GRP,
> TWL4030_PM_RECEIVER_DEV_GRP_P1);
> +
> + /* Set VMMC2 to 3.15 Volts */
> + twl4030_pmrecv_vsel_cfg(TWL4030_PM_RECEIVER_VMMC2_DEDICATED,
> + TWL4030_PM_RECEIVER_VMMC2_VSEL_32,
> + TWL4030_PM_RECEIVER_VMMC2_DEV_GRP,
> + TWL4030_PM_RECEIVER_DEV_GRP_P1);
> }
> diff --git a/include/twl4030.h b/include/twl4030.h
> index 093c61d..18795a6 100644
> --- a/include/twl4030.h
> +++ b/include/twl4030.h
> @@ -395,6 +395,8 @@
> #define TWL4030_PM_RECEIVER_VDAC_VSEL_18 0x03
> #define TWL4030_PM_RECEIVER_VMMC1_VSEL_30 0x02
> #define TWL4030_PM_RECEIVER_VMMC1_VSEL_32 0x03
> +#define TWL4030_PM_RECEIVER_VMMC2_VSEL_30 0x0B
> +#define TWL4030_PM_RECEIVER_VMMC2_VSEL_32 0x0C
> #define TWL4030_PM_RECEIVER_VSIM_VSEL_18 0x03
>
> /* Device Selection in PM Receiver Module */
> --
> 1.7.9.5
Acked-by: Pantelis Antoniou <panto@antoniou-consulting.com>
Thanks, applied.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH v2] twl4030: VMMC2 3.2V enable on MMC init
2014-10-28 17:14 ` [U-Boot] [PATCH v2] twl4030: " Paul Kocialkowski
2014-10-30 15:22 ` Pantelis Antoniou
@ 2014-10-30 23:35 ` Anatolij Gustschin
1 sibling, 0 replies; 6+ messages in thread
From: Anatolij Gustschin @ 2014-10-30 23:35 UTC (permalink / raw)
To: u-boot
On Tue, 28 Oct 2014 18:14:23 +0100
Paul Kocialkowski <contact@paulk.fr> wrote:
> This enables the VMMC2 LDO, which powers the MMC2 device.
> When the device starts from MMC2, this has already been enabled by the BootROM,
> but when starting from peripheral boot (USB, UART), it is not the case.
>
> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> ---
> drivers/power/twl4030.c | 6 ++++++
> include/twl4030.h | 2 ++
> 2 files changed, 8 insertions(+)
applied to u-boot-staging. Thanks!
Anatolij
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-10-30 23:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-28 14:05 [U-Boot] [PATCH] twl4030: TWL4030 VMMC2 3.2V enable on MMC init Paul Kocialkowski
2014-10-28 15:47 ` Igor Grinberg
2014-10-28 16:04 ` Paul Kocialkowski
2014-10-28 17:14 ` [U-Boot] [PATCH v2] twl4030: " Paul Kocialkowski
2014-10-30 15:22 ` Pantelis Antoniou
2014-10-30 23:35 ` Anatolij Gustschin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox