From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] usb: ehci: rmobile: Add support R8A7793
Date: Tue, 4 Nov 2014 09:13:10 +0100 [thread overview]
Message-ID: <201411040913.10677.marex@denx.de> (raw)
In-Reply-To: <CABMQnV+79gq_gHxCCjd9iUXatOXz7cuc6raervF=_W25ORYG-A@mail.gmail.com>
On Tuesday, November 04, 2014 at 08:10:30 AM, Nobuhiro Iwamatsu wrote:
> Hi!
Hi!
[...]
> > btw. just an idea, but you don't need to explicitly use
> > usb_base_address[CONFIG_USB_MAX_CONTROLLER_COUNT], you can
> > just use usb_base_address[] in the array definition. Then,
> > in the code, you can just use "ARRAY_SIZE(usb_base_address) - 1"
> > instead of CONFIG_USB_MAX_CONTROLLER_COUNT . This rids you of
> > one annoying macro in that driver ;-) If you want to implement
> > this, then please do so, but in a separate patch.
>
> Indeed. I will create a patch which fix your point.
>
> > I'll pick these two patches now.
>
> Thanks!
Thank you, I will queue it for the next PR, since I sent this one out
already.
Best regards,
Marek Vasut
prev parent reply other threads:[~2014-11-04 8:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 0:56 [U-Boot] [PATCH 1/2] usb: ehci: rmobile: Add support R8A7793 Nobuhiro Iwamatsu
2014-11-04 0:56 ` [U-Boot] [PATCH 2/2] usb: ehci: rmobile: Collect up address data Nobuhiro Iwamatsu
2014-11-04 5:02 ` [U-Boot] [PATCH 1/2] usb: ehci: rmobile: Add support R8A7793 Marek Vasut
2014-11-04 7:10 ` Nobuhiro Iwamatsu
2014-11-04 8:13 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201411040913.10677.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox