[U-Boot] [PATCH 08/11] omap3: cm-t3517: add basic board support

Tom Rini
2014-11-05T12:23:05Z

On Wed, Nov 05, 2014 at 02:16:35PM +0200, Igor Grinberg wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hi Tom,
>
> On 11/04/14 18:46, Tom Rini wrote:
> > On Mon, Nov 03, 2014 at 11:32:24AM +0200, Igor Grinberg wrote:
> >
> >> CompuLab cm-t3517 is Computer on Module (CoM) based on AM3517 SoC.
> >> Features: up to 256MB DDR2, up to 512MB NAND, USB hub, mUSB, WiFi, BT,
> >> Analog audio codec, touch screen controller, LED.
> >>
> >> Add basic support including:
> >> LED, Serial console, NAND, MMC, GPIO, I2C, 256MB DRAM.
> >>
> >> Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
> > [snip]
> >> +/*
> >> + * The early kernel mapping on ARM currently only maps from the base of DRAM
> >> + * to the end of the kernel image. The kernel is loaded at DRAM base + 0x8000.
> >> + * The early kernel pagetable uses DRAM base + 0x4000 to DRAM base + 0x8000,
> >> + * so that leaves DRAM base to DRAM base + 0x4000 available.
> >> + */
> >> +#define CONFIG_SYS_BOOTMAPSZ 0x4000
> >
> > The big comment about layout at the top of
> > include/configs/ti_armv7_common.h applies to omap3 too, are you sure you
> > want to go in the direction instead? In fact, are you sure you can't /
> > don't want to leverage that file?
>
> Well, the only concern about the using common configurations in general
> is the breakage it can introduce as changes to those files are never tested
> on all the boards that include them. Hopefully, this will be (at least
> partially) solved by defconfigs.
> As same stands also for fixes, I think we can take the chances.
> Switching to use the common config file will require some additional checks
> like undef unneeded stuff and also check the binary size impact.
> I might be unable to do those soon enough for this patchset to be included
> in the release.

OK.

> >> +#define CONFIG_SYS_BAUDRATE_TABLE {4800, 9600, 19200, 38400, 57600,\
> >> + 115200}
> >
> > Use the default table?
>
> Do you mean the one in ti_omap3_common.h?
> Well, that is the same question as above (and also the same answer).

Aaand now I have egg on my face, I was referring to
include/config_fallbacks.h

> The question is can we proceed with only the below fixed and I will update
> the above and common config file inclusion later (also for cm-t35)?

... maybe. I need to think about it I suppose.

--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141105/35b89647/attachment.pgp>