[U-Boot] [PATCH 08/11] omap3: cm-t3517: add basic board support

Igor Grinberg
2014-11-05T12:16:35Z

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Tom,

On 11/04/14 18:46, Tom Rini wrote:
> On Mon, Nov 03, 2014 at 11:32:24AM +0200, Igor Grinberg wrote:
>
>> CompuLab cm-t3517 is Computer on Module (CoM) based on AM3517 SoC.
>> Features: up to 256MB DDR2, up to 512MB NAND, USB hub, mUSB, WiFi, BT,
>> Analog audio codec, touch screen controller, LED.
>>
>> Add basic support including:
>> LED, Serial console, NAND, MMC, GPIO, I2C, 256MB DRAM.
>>
>> Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
> [snip]
>> +/*
>> + * The early kernel mapping on ARM currently only maps from the base of DRAM
>> + * to the end of the kernel image. The kernel is loaded at DRAM base + 0x8000.
>> + * The early kernel pagetable uses DRAM base + 0x4000 to DRAM base + 0x8000,
>> + * so that leaves DRAM base to DRAM base + 0x4000 available.
>> + */
>> +#define CONFIG_SYS_BOOTMAPSZ 0x4000
>
> The big comment about layout at the top of
> include/configs/ti_armv7_common.h applies to omap3 too, are you sure you
> want to go in the direction instead? In fact, are you sure you can't /
> don't want to leverage that file?

Well, the only concern about the using common configurations in general
is the breakage it can introduce as changes to those files are never tested
on all the boards that include them. Hopefully, this will be (at least
partially) solved by defconfigs.
As same stands also for fixes, I think we can take the chances.
Switching to use the common config file will require some additional checks
like undef unneeded stuff and also check the binary size impact.
I might be unable to do those soon enough for this patchset to be included
in the release.

>
>> +#define CONFIG_SYS_BAUDRATE_TABLE {4800, 9600, 19200, 38400, 57600,\
>> + 115200}
>
> Use the default table?

Do you mean the one in ti_omap3_common.h?
Well, that is the same question as above (and also the same answer).

The question is can we proceed with only the below fixed and I will update
the above and common config file inclusion later (also for cm-t35)?

>
>> +#define CONFIG_SYS_MEMTEST_START (OMAP34XX_SDRC_CS0) /* memtest */
>> + /* works on */
>> +#define CONFIG_SYS_MEMTEST_END (OMAP34XX_SDRC_CS0 + \
>> + 0x01F00000) /* 31MB */
>
> Really want this on? See doc/README.memory-test

No, not really... Thanks for pointing to this.
I usually try to keep myself up to date, but recently, I have
way to much stuff going on, so those small things are slipping through.

- --
Regards,
Igor.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBAgAGBQJUWhUjAAoJEBDE8YO64EfahvsP/iVwljxV3L9R3MXYnv9UrD0V
iId1gURxQXATU9lSLIXM6RTfAGLCGFkemASxTWNNMy1LpvxXxBfvrRmIGpK1Z26f
ydpOmp1yCiSoYLSXnFUqOHmiqdi/IA/URDPAWlzoXD6qfRIah1b/P2Ajdc+3rQS6
dmESDdyYj37aKIeeMtLbqhup9qG8Tm3YgF7S95K3dDAiVG9/HQtj7ccCVhh+ML2u
u0TQ+YVfp8oPHQULw2IzXNwLQ7cZq7pTU5QmVx7YgDNNdi+ULH1Zjwv5zQtUx29c
R9cdOpzTKrp94BzZIAkyzKuqKUmr4psaI3gfyFzCh8ow25knh7xXdRYmYpkzjWgS
Sf04CGccv5iOC/kJWjuidj1QtmmBt7BhlD4/EfETzeQT/cnzHJL6suR2XL2mKcC2
YfPYnz2pLqAgDi14km34ZwWWtXn+rqAEf5Z49BqyngIeOytFcAGNptsFOMLOgRYr
/MahOwEE/1aaEa/v5b5onStvakrXLkVoOhEvqtIdyCmRUG/ENKwFmNI8ECJTdoN3
mhzvaSQAlEiY7uWjyq57uu/2ltcbUYsvHZA03WS2RaQGhAYydfNbagg+wjuh3774
lfT+RAk0d+jN+zB9IUysQVPUaXckMOtylxxLs4m9sq75qVzM9B5dS041c13qvlqE
D2t0+Z5Ipi4v04+2b588
=T9e1
-----END PGP SIGNATURE-----