From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pavel Machek <pavel@denx.de>
Date: Tue, 4 Nov 2014 20:36:57 +0100
Subject: [U-Boot] [PATCH 4/5] usb: s3c-otg: Allow custom gusbcfg
In-Reply-To: <1415077654-17181-4-git-send-email-marex@denx.de>
References: <1415077654-17181-1-git-send-email-marex@denx.de>
	<1415077654-17181-4-git-send-email-marex@denx.de>
Message-ID: <20141104193657.GE13607@amd>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Tue 2014-11-04 06:07:33, Marek Vasut wrote:
> Allow passing in a custom configuration of the gusbcfg register
> via platform data.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Chin Liang See <clsee@altera.com>
> Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
> Cc: Vince Bridgers <vbridger@altera.com>

Acked-by: Pavel Machek <pavel@denx.de>

>  	debug("Reseting OTG controller\n");
>  
> -	writel(0<<15		/* PHY Low Power Clock sel*/
> +	dflt_gusbcfg =
> +		0<<15		/* PHY Low Power Clock sel*/
>  		|1<<14		/* Non-Periodic TxFIFO Rewind Enable*/
>  		|0x5<<10	/* Turnaround time*/
>  		|0<<9 | 0<<8	/* [0:HNP disable,1:HNP enable][ 0:SRP disable*/
> @@ -413,8 +415,12 @@ static void reconfig_usbd(void)
>  		|0<<6		/* 0: high speed utmi+, 1: full speed serial*/
>  		|0<<4		/* 0: utmi+, 1:ulpi*/
>  		|1<<3		/* phy i/f  0:8bit, 1:16bit*/
> -		|0x7<<0,	/* HS/FS Timeout**/
> -		&reg->gusbcfg);
> +		|0x7<<0;	/* HS/FS Timeout**/
> +

"Interesting" comment style. And I'd remove 0x prefixes from constants
<8...


-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html