[U-Boot] [PATCH 3/5] usb: s3c-otg: Split out PHY control

Marek Vasut
2014-11-06T20:26:00Z

On Tuesday, November 04, 2014 at 08:34:21 PM, Pavel Machek wrote:
> On Tue 2014-11-04 06:07:32, Marek Vasut wrote:
> > Split the Samsung specific PHY control into a separate file
> > and compile this into the S3C OTG driver only if used on a
> > Samsung system.
> >
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Chin Liang See <clsee@altera.com>
> > Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
> > Cc: Vince Bridgers <vbridger@altera.com>
>
> Acked-by: Pavel Machek <pavel@denx.de>
>
> I know you are just moving the code, but...
>
> > +void otg_phy_init(struct s3c_udc *dev)
> > +{
> > + unsigned int usb_phy_ctrl = dev->pdata->usb_phy_ctrl;
> > + struct s3c_usbotg_phy *phy =
> > + (struct s3c_usbotg_phy *)dev->pdata->regs_phy;
> > +
> > + dev->pdata->phy_control(1);
> > +
> > + /*USB PHY0 Enable */
>
> Wrong comment style.

I'll fix this one.

> > + printf("USB PHY0 Enable\n");
> > +
> > + /* Enable PHY */
> > + writel(readl(usb_phy_ctrl) | USB_PHY_CTRL_EN0, usb_phy_ctrl);
>
> We have helpers for setting/clearing bits, right?

Yes we do, Lukasz ... ? :)

Best regards,
Marek Vasut