From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Wed, 5 Nov 2014 10:01:23 +0100
Subject: [U-Boot] [PATCH 6/6] linux/kernel.h: sync min, max, min3,
	max3 macros with Linux
In-Reply-To: <20141105171239.CB3C.AA925319@jp.panasonic.com>
References: <20141105164818.CB31.AA925319@jp.panasonic.com>
	<201411050857.50148.marex@denx.de>
	<20141105171239.CB3C.AA925319@jp.panasonic.com>
Message-ID: <201411051001.23455.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Wednesday, November 05, 2014 at 09:12:40 AM, Masahiro Yamada wrote:
> Hi Marek,

Hi Masahiro,

> On Wed, 5 Nov 2014 08:57:50 +0100
> 
> Marek Vasut <marex@denx.de> wrote:
> > On Wednesday, November 05, 2014 at 08:48:19 AM, Masahiro Yamada wrote:
> > > Hi Marek,
> > 
> > Hi!
> > 
> > > (reduced Cc)
> > > 
> > > On Wed, 5 Nov 2014 07:02:23 +0100
> > > 
> > > Marek Vasut <marex@denx.de> wrote:
> > > > On Wednesday, November 05, 2014 at 06:06:09 AM, Masahiro Yamada wrote:
> > > > > Hi Pavel,
> > > > > 
> > > > > Thanks for your close checking.
> > > > > 
> > > > > 
> > > > > On Tue, 4 Nov 2014 20:50:13 +0100
> > > > > 
> > > > > Pavel Machek <pavel@denx.de> wrote:
> > > > > > On Tue 2014-11-04 20:26:26, Masahiro Yamada wrote:
> > > > > > > U-Boot has never cared about the type when we get max/min of
> > > > > > > two values, but Linux Kernel does.  This commit gets min, max,
> > > > > > > min3, max3 macros synced with the kernel introduing type
> > > > > > > checks.
> > > > > > 
> > > > > > "introducing"
> > > > > 
> > > > > I will fix this.
> > > > 
> > > > Are you linting the patches with aspell or something ?
> > > 
> > > No.
> > > Going forward I will do that. Thaks for your advice!
> > 
> > I was just curious what Pavel does there, since I also got some spelling
> > corrections from him. Please don't take it like I want to add more work
> > on your plate.
> 
> I was not sure if your question was addressed to me or Pavel,
> but never mind.
> 
> I use nano editor for inputting git-log.
> It is just to press Ctrl-T to invoke aspell,
> so it will not load me with much work.
> Resending a patch just for a typo is a more tedious work.

Right, I'd be fine if the committer could just fix it without the need
for resend ...

> (Pavel, don't get me wrong.  All you pointed out are good things.)

btw. I have this precommit hook to invoke checkpatch and you can possibly
add a postcommit (?) hook to invoke aspell too. Just a hint though ...

-->8--
marex at bfu:u-boot$ cat .git/hooks/pre-commit
#!/bin/sh
#
# pre-commit hook to run check-patch on the output and stop any commits
# that do not pass. Note, only for git-commit, and not for any of the
# other scenarios
#
# Copyright 2010 Ben Dooks, <ben-linux@fluff.org>

if git rev-parse --verify HEAD 2>/dev/null >/dev/null
then
        against=HEAD
else
        # Initial commit: diff against an empty tree object
        against=4b825dc642cb6eb9a060e54bf8d69288fbee4904
fi

git diff --cached $against -- | ./scripts/checkpatch.pl --no-signoff -
--8<--

Best regards,
Marek Vasut