From: Masahiro Yamada <yamada.m@jp.panasonic.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] nand: reinstate lazy bad block scanning
Date: Wed, 05 Nov 2014 12:40:13 +0900 [thread overview]
Message-ID: <20141105124013.CB21.AA925319@jp.panasonic.com> (raw)
In-Reply-To: <1415050949.23458.268.camel@snotra.buserror.net>
Hi Scott, Rostislav,
On Mon, 3 Nov 2014 15:42:29 -0600
Scott Wood <scottwood@freescale.com> wrote:
> On Wed, 2014-10-22 at 13:40 +0200, Rostislav Lisovy wrote:
> > Commit ff94bc40af3481d47546595ba73c136de6af6929
> > ("mtd, ubi, ubifs: resync with Linux-3.14")
> > accidentally reverted part of the commit
> > 13f0fd94e3cae6f8a0d9fba5d367e311edc8ebde
> > ("NAND: Scan bad blocks lazily.").
> >
> > Reinstate the change as by commit
> > fb49454b1b6c7c6e238ac3c0b1e302e73eb1a1ea
> > ("nand: reinstate lazy bad block scanning")
> >
> > Signed-off-by: Rostislav Lisovy <lisovy@merica.cz>
> > ---
> > drivers/mtd/nand/nand_base.c | 10 +++++++---
> > 1 file changed, 7 insertions(+), 3 deletions(-)
>
> Thanks for catching this.
>
> Heiko, this is the sort of thing I was concerned about with the "resync
> from scratch" approach.
>
I do not believe resync is a bad idea,
of course we should be very careful not to break existing features.
I recommend to surround this code with "#ifdef __UBOOT__ ... #endif"
as we have done for the other parts.
BTW, we attempt to probe NAND devices during the boot sequence
just for displaying the device size, right?
NAND: **** MiB
If so, can we postpone the whole of nand_scan
until we use it? I am not sure about this, though.
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2014-11-05 3:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-22 11:40 [U-Boot] [PATCH] nand: reinstate lazy bad block scanning Rostislav Lisovy
2014-11-03 21:42 ` Scott Wood
2014-11-05 3:40 ` Masahiro Yamada [this message]
2014-11-05 5:49 ` Scott Wood
2014-11-05 8:01 ` Masahiro Yamada
2014-11-05 13:52 ` Heiko Schocher
-- strict thread matches above, loose matches on Subject: below --
2012-02-20 20:56 Scott Wood
2012-02-21 6:44 ` Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141105124013.CB21.AA925319@jp.panasonic.com \
--to=yamada.m@jp.panasonic.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox