From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Wed, 5 Nov 2014 16:31:04 -0500 Subject: [U-Boot] [U-Boot, 07/11] omap: hsmmc: assume cd gpio is active low In-Reply-To: <1415007147-12562-8-git-send-email-grinberg@compulab.co.il> References: <1415007147-12562-8-git-send-email-grinberg@compulab.co.il> Message-ID: <20141105213104.GA15133@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, Nov 03, 2014 at 11:32:23AM +0200, Igor Grinberg wrote: > Switch the default CD GPIO polarity to active low. > > The current hsmmc driver assumption that the CD GPIO is active high, but > in the real hardware, usually the opposite holds. > The usual SD card socket has a mechanical switch which is grounded as > soon as a card is inserted. > Of course there might be some board logic which inverts the signal, but > as far as current users are concerned, there is no such logic. > > Current U-Boot users either not using the CD functionality, or have a > different way (e.g. external to SoC GPIO controller) for checking the > card presence. > > This patch also brings the polarity assumption in line with the Linux > kernel and adds appropriate comments. > > This patch also might spare issues once the TWL GPIO driver will be > converted to the DM. > > Signed-off-by: Igor Grinberg > Cc: Pantelis Antoniou > Cc: Dmitry Lifshitz > Reviewed-by: Tom Rini Applied to u-boot-ti/master, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: