From: Lukasz Majewski <l.majewski@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 2/2] Odroid-XU3: Add support for Odroid-XU3
Date: Thu, 06 Nov 2014 09:50:51 +0100 [thread overview]
Message-ID: <20141106095051.51e12938@amdc2363> (raw)
In-Reply-To: <20141106130631.2c5bc55a@hwh-linux>
Hi Hyungwon,
> Dear Lukasz Majewski,
>
> On Wed, 05 Nov 2014 11:29:53 +0100
> Lukasz Majewski <l.majewski@samsung.com> wrote:
>
> > > +#undef CONFIG_EXYNOS_SPL
> > > +#undef CONFIG_SILENT_CONSOLE
> > > +#undef CONFIG_CROS_EC
> > > +#undef CONFIG_CROS_EC_SPI
> > > +#undef CONFIG_CROS_EC_I2C
> > > +#undef CONFIG_CROS_EC_KEYB
> > > +#undef CONFIG_CMD_CROS_EC
> > > +#undef CONFIG_KEYBOARD
> > > +#undef CONFIG_SPI_BOOTING
> > > +#undef CONFIG_ENV_IS_IN_SPI_FLASH
> > > +#undef CONFIG_SPI_FLASH
> > > +#undef CONFIG_EXYNOS_SPI
> > > +#undef CONFIG_CMD_SF
> > > +#undef CONFIG_CMD_SPI
> > > +#undef CONFIG_SPI_FLASH_WINBOND
> > > +#undef CONFIG_SPI_FLASH_GIGADEVICE
> > > +#undef CONFIG_OF_SPI
> > > +#undef CONFIG_FIT_BEST_MATCH
> > > +#undef CONFIG_USB_BOOTING
> > > +#undef CONFIG_CMD_NET
> > > +#undef CONFIG_SMC911X
> > > +#undef CONFIG_CMD_PXE
> > > +#undef CONFIG_MENU
> > > +#undef CONFIG_ENV_IS_IN_SPI_FLASH
> >
> > Cannot we just remove those CONFIG_* , instead of using #undef?
> >
>
> We can remove all of them without harm or at least no error in
> operation except for CONFIG_CMD_NET. Some boards including chromebook
> uses common config file with Odroid XU3. I don't know whether they
> need ethernet driver for their work or not. I have no device. Will it
> be good to remove the config from exynos5-common.h and add them to
> the config file which inherit exynos5-common.h?
I think that we can keep only the CONFIG_CMD_NET if it doesn't hurt XU3
build.
>
> Best regards,
> Hyungwon Hwang
>
--
Best regards,
Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
next prev parent reply other threads:[~2014-11-06 8:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-05 4:04 [U-Boot] [PATCH v3 0/2] Adds support for Exynos5422 odroid xu3 board Hyungwon Hwang
2014-11-05 4:04 ` [U-Boot] [PATCH v3 1/2] exynos5: fix GPIO information of exynos5420 Hyungwon Hwang
2014-11-05 10:20 ` Lukasz Majewski
2014-11-05 4:04 ` [U-Boot] [PATCH v3 2/2] Odroid-XU3: Add support for Odroid-XU3 Hyungwon Hwang
2014-11-05 10:29 ` Lukasz Majewski
2014-11-06 4:06 ` Hyungwon Hwang
2014-11-06 8:50 ` Lukasz Majewski [this message]
2014-11-05 10:08 ` [U-Boot] [PATCH v3 0/2] Adds support for Exynos5422 odroid xu3 board Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141106095051.51e12938@amdc2363 \
--to=l.majewski@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox