From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Date: Thu, 06 Nov 2014 09:50:51 +0100 Subject: [U-Boot] [PATCH v3 2/2] Odroid-XU3: Add support for Odroid-XU3 In-Reply-To: <20141106130631.2c5bc55a@hwh-linux> References: <1415160270-12546-1-git-send-email-human.hwang@samsung.com> <1415160270-12546-3-git-send-email-human.hwang@samsung.com> <20141105112953.67fe9c19@amdc2363> <20141106130631.2c5bc55a@hwh-linux> Message-ID: <20141106095051.51e12938@amdc2363> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Hyungwon, > Dear Lukasz Majewski, > > On Wed, 05 Nov 2014 11:29:53 +0100 > Lukasz Majewski wrote: > > > > +#undef CONFIG_EXYNOS_SPL > > > +#undef CONFIG_SILENT_CONSOLE > > > +#undef CONFIG_CROS_EC > > > +#undef CONFIG_CROS_EC_SPI > > > +#undef CONFIG_CROS_EC_I2C > > > +#undef CONFIG_CROS_EC_KEYB > > > +#undef CONFIG_CMD_CROS_EC > > > +#undef CONFIG_KEYBOARD > > > +#undef CONFIG_SPI_BOOTING > > > +#undef CONFIG_ENV_IS_IN_SPI_FLASH > > > +#undef CONFIG_SPI_FLASH > > > +#undef CONFIG_EXYNOS_SPI > > > +#undef CONFIG_CMD_SF > > > +#undef CONFIG_CMD_SPI > > > +#undef CONFIG_SPI_FLASH_WINBOND > > > +#undef CONFIG_SPI_FLASH_GIGADEVICE > > > +#undef CONFIG_OF_SPI > > > +#undef CONFIG_FIT_BEST_MATCH > > > +#undef CONFIG_USB_BOOTING > > > +#undef CONFIG_CMD_NET > > > +#undef CONFIG_SMC911X > > > +#undef CONFIG_CMD_PXE > > > +#undef CONFIG_MENU > > > +#undef CONFIG_ENV_IS_IN_SPI_FLASH > > > > Cannot we just remove those CONFIG_* , instead of using #undef? > > > > We can remove all of them without harm or at least no error in > operation except for CONFIG_CMD_NET. Some boards including chromebook > uses common config file with Odroid XU3. I don't know whether they > need ethernet driver for their work or not. I have no device. Will it > be good to remove the config from exynos5-common.h and add them to > the config file which inherit exynos5-common.h? I think that we can keep only the CONFIG_CMD_NET if it doesn't hurt XU3 build. > > Best regards, > Hyungwon Hwang > -- Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group