public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Lukasz Majewski <l.majewski@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 6/6] linux/kernel.h: sync min, max, min3, max3 macros with Linux
Date: Thu, 6 Nov 2014 10:22:23 +0100	[thread overview]
Message-ID: <20141106102223.29e86a2c@amdc2363> (raw)
In-Reply-To: <1415100418-29016-7-git-send-email-yamada.m@jp.panasonic.com>

Hi Masahiro,

> U-Boot has never cared about the type when we get max/min of two
> values, but Linux Kernel does.  This commit gets min, max, min3, max3
> macros synced with the kernel introduing type checks.
> 
> Many of references of those macros must be fixed to suppress warnings.
> We have two options:
>  - Use min, max, min3, max3 only when the arguments have the same type
>    (or add casts to the arguments)
>  - Use min_t/max_t instead with the appropriate type for the first
>    argument
> 
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> ---
> 
>  arch/arm/cpu/arm1176/tnetv107x/clock.c    |  5 ++-
>  arch/arm/cpu/armv7/exynos/clock.c         |  4 +-
>  arch/arm/cpu/armv7/tegra20/display.c      |  4 +-
>  arch/avr32/cpu/at32ap700x/clk.c           |  2 +-
>  arch/blackfin/cpu/jtag-console.c          |  2 +-
>  arch/blackfin/lib/string.c                |  2 +-
>  arch/powerpc/cpu/mpc85xx/tlb.c            |  2 +-
>  arch/powerpc/cpu/ppc4xx/44x_spd_ddr2.c    | 32 ++++++++++------
>  arch/powerpc/lib/bootm.c                  |  2 +-
>  arch/sandbox/cpu/start.c                  |  2 +-
>  arch/x86/cpu/coreboot/pci.c               |  2 +-
>  arch/x86/cpu/coreboot/sdram.c             |  2 +-
>  board/freescale/common/sys_eeprom.c       |  6 +--
>  board/gdsys/p1022/controlcenterd-id.c     |  5 ++-
>  board/imgtec/malta/malta.c                |  2 +-
>  common/cmd_elf.c                          | 12 +++---
>  common/cmd_sf.c                           | 16 ++++----
>  common/env_nand.c                         |  4 +-
>  common/fdt_support.c                      |  3 +-
>  common/lcd.c                              |  6 +--
>  common/usb_hub.c                          |  3 +-
>  drivers/block/ahci.c                      |  2 +-
>  drivers/ddr/fsl/ctrl_regs.c               | 22 +++++------
>  drivers/ddr/fsl/lc_common_dimm_params.c   | 62
> ++++++++++++++++++-------------
> drivers/ddr/fsl/main.c                    |  3 +-
> drivers/dfu/dfu.c                         |  2 +-
> drivers/i2c/fsl_i2c.c                     |  2 +-
> drivers/misc/cros_ec_spi.c                |  2 +-
> drivers/mmc/fsl_esdhc.c                   |  2 +-
> drivers/mmc/pxa_mmc_gen.c                 |  6 +--
> drivers/mtd/nand/denali_spl.c             |  2 +-
> drivers/mtd/spi/sandbox.c                 |  2 +-
> drivers/mtd/spi/sf_ops.c                  |  5 ++-
> drivers/net/netconsole.c                  |  2 +-
> drivers/pci/pci.c                         |  6 ++-
> drivers/pci/pci_auto.c                    |  2 +-
> drivers/serial/usbtty.c                   |  2 +-
> drivers/spi/fsl_espi.c                    |  4 +-
> drivers/spi/mxc_spi.c                     |  2 +-
> drivers/spi/spi-uclass.c                  |  2 +-
> drivers/tpm/tpm_tis_lpc.c                 |  2 +-
> drivers/usb/gadget/composite.c            |  4 +-
> drivers/usb/gadget/designware_udc.c       |  4 +-
> drivers/usb/gadget/pxa27x_udc.c           |  3 +-
> drivers/usb/gadget/s3c_udc_otg_xfer_dma.c |  4 +-

From my side:
Acked-by: Lukasz Majewski <l.majewski@samsung.com>

Tested-by: Lukasz Majewski <l.majewski@samsung.com>

Test HW: Trats2 (Exynos4412)

-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group

      parent reply	other threads:[~2014-11-06  9:22 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-04 11:26 [U-Boot] [PATCH 0/6] Collect utility macros to include/linux/kernel.h synced with Linux Masahiro Yamada
2014-11-04 11:26 ` [U-Boot] [PATCH 1/6] replace DIV_ROUND with DIV_ROUND_CLOSEST Masahiro Yamada
2014-11-04 11:26 ` [U-Boot] [PATCH 2/6] include/common.h: remove DIV_ROUND definition Masahiro Yamada
2014-11-04 11:26 ` [U-Boot] [PATCH 3/6] include: move various macros to include/linux/kernel.h Masahiro Yamada
2014-11-04 11:26 ` [U-Boot] [PATCH 4/6] linux/kernel.h: import more macros Masahiro Yamada
2014-11-04 11:26 ` [U-Boot] [PATCH 5/6] linux/kernel.h: add typechecking to roundup macro Masahiro Yamada
2014-11-04 11:26 ` [U-Boot] [PATCH 6/6] linux/kernel.h: sync min, max, min3, max3 macros with Linux Masahiro Yamada
2014-11-04 19:50   ` Pavel Machek
2014-11-05  5:06     ` Masahiro Yamada
2014-11-05  6:02       ` Marek Vasut
2014-11-05  7:48         ` Masahiro Yamada
2014-11-05  7:57           ` Marek Vasut
2014-11-05  8:12             ` Masahiro Yamada
2014-11-05  9:01               ` Marek Vasut
2014-11-06 11:59         ` Pavel Machek
2014-11-06  9:22   ` Lukasz Majewski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141106102223.29e86a2c@amdc2363 \
    --to=l.majewski@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox