From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/9] drivers/usb/host/isp116x-hcd.c: fix syntax error
Date: Thu, 6 Nov 2014 14:23:46 +0100 [thread overview]
Message-ID: <201411061423.46229.marex@denx.de> (raw)
In-Reply-To: <1415278985-8482-4-git-send-email-wd@denx.de>
On Thursday, November 06, 2014 at 02:02:59 PM, Wolfgang Denk wrote:
> Fix error detected by cppcheck:
>
> [drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of
> character (() when these macros are defined: ''.
> [drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of
> character (() when these macros are defined: 'ISP116X_HCD_OC_ENABLE'.
> [drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of
> character (() when these macros are defined:
> 'ISP116X_HCD_REMOTE_WAKEUP_ENABLE'.
> [drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of
> character (() when these macros are defined: 'ISP116X_HCD_SEL15kRES'.
> [drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of
> character (() when these macros are defined:
> 'ISP116X_HCD_USE_EXTRA_DELAY'.
> [drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of
> character (() when these macros are defined: 'ISP116X_HCD_USE_UDELAY'.
> [drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of
> character (() when these macros are defined: 'TRACE'.
> [drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of
> character (() when these macros are defined: 'TRACE;VERBOSE'.
> [drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of
> character (() when these macros are defined: 'VERBOSE'.
>
> Signed-off-by: Wolfgang Denk <wd@denx.de>
> Cc: Stephen Warren <swarren@wwwdotorg.org>
> Cc: Marek Vasut <marex@denx.de>
A brief grep:
marex at bfu:u-boot$ git grep USB_ISP116X_HCD
drivers/usb/host/Makefile:obj-$(CONFIG_USB_ISP116X_HCD) += isp116x-hcd.o
include/usb.h: defined(CONFIG_USB_SL811HS) || defined(CONFIG_USB_ISP116X_HCD)
|| \
marex at bfu:u-boot$
gives me a better idea on how to resolve this bug ... scrap this code
altogether. Looks like the code was unused forever. Can you prepare a
patch for that please ?
Best regards,
Marek Vasut
next prev parent reply other threads:[~2014-11-06 13:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-06 13:02 [U-Boot] [PATCH 0/9] cppcheck cleanup Wolfgang Denk
2014-11-06 13:02 ` [U-Boot] [PATCH 1/9] cppcheck cleanup: fix nullPointer errors Wolfgang Denk
2014-11-10 21:27 ` [U-Boot] [U-Boot,1/9] " Tom Rini
2014-11-06 13:02 ` [U-Boot] [PATCH 2/9] board/cogent/lcd.c: fix syntax error Wolfgang Denk
2014-11-10 21:28 ` [U-Boot] [U-Boot,2/9] " Tom Rini
2014-11-06 13:02 ` [U-Boot] [PATCH 3/9] drivers/usb/host/isp116x-hcd.c: " Wolfgang Denk
2014-11-06 13:23 ` Marek Vasut [this message]
2014-11-06 13:03 ` [U-Boot] [PATCH 4/9] drivers/net/uli526x.c: " Wolfgang Denk
2014-11-10 21:28 ` [U-Boot] [U-Boot,4/9] " Tom Rini
2014-11-06 13:03 ` [U-Boot] [PATCH 5/9] common/cmd_fitupd.c: restore corrupted file Wolfgang Denk
2014-11-10 21:28 ` [U-Boot] [U-Boot, " Tom Rini
2014-11-06 13:03 ` [U-Boot] [PATCH 6/9] board/matrix_vision/mvblx/sys_eeprom.c: fix buffer overflow Wolfgang Denk
2014-11-06 13:50 ` Michael Jones
2014-11-10 21:28 ` [U-Boot] [U-Boot, " Tom Rini
2014-11-06 13:03 ` [U-Boot] [PATCH 7/9] board/renesas/ecovec/ecovec.c: " Wolfgang Denk
2014-11-09 23:52 ` Nobuhiro Iwamatsu
2014-11-06 13:03 ` [U-Boot] [PATCH 8/9] ARM: MXS: fix Uninitialized variable error Wolfgang Denk
2014-11-10 21:28 ` [U-Boot] [U-Boot, " Tom Rini
2014-11-06 13:03 ` [U-Boot] [PATCH 9/9] board/esd/common/auto_update.c: fix Uninitialized variable Wolfgang Denk
2014-11-06 13:33 ` Matthias Fuchs
2014-11-10 21:28 ` [U-Boot] [U-Boot, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201411061423.46229.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox