From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Thu, 6 Nov 2014 14:23:46 +0100 Subject: [U-Boot] [PATCH 3/9] drivers/usb/host/isp116x-hcd.c: fix syntax error In-Reply-To: <1415278985-8482-4-git-send-email-wd@denx.de> References: <1415278985-8482-1-git-send-email-wd@denx.de> <1415278985-8482-4-git-send-email-wd@denx.de> Message-ID: <201411061423.46229.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thursday, November 06, 2014 at 02:02:59 PM, Wolfgang Denk wrote: > Fix error detected by cppcheck: > > [drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of > character (() when these macros are defined: ''. > [drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of > character (() when these macros are defined: 'ISP116X_HCD_OC_ENABLE'. > [drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of > character (() when these macros are defined: > 'ISP116X_HCD_REMOTE_WAKEUP_ENABLE'. > [drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of > character (() when these macros are defined: 'ISP116X_HCD_SEL15kRES'. > [drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of > character (() when these macros are defined: > 'ISP116X_HCD_USE_EXTRA_DELAY'. > [drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of > character (() when these macros are defined: 'ISP116X_HCD_USE_UDELAY'. > [drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of > character (() when these macros are defined: 'TRACE'. > [drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of > character (() when these macros are defined: 'TRACE;VERBOSE'. > [drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of > character (() when these macros are defined: 'VERBOSE'. > > Signed-off-by: Wolfgang Denk > Cc: Stephen Warren > Cc: Marek Vasut A brief grep: marex at bfu:u-boot$ git grep USB_ISP116X_HCD drivers/usb/host/Makefile:obj-$(CONFIG_USB_ISP116X_HCD) += isp116x-hcd.o include/usb.h: defined(CONFIG_USB_SL811HS) || defined(CONFIG_USB_ISP116X_HCD) || \ marex at bfu:u-boot$ gives me a better idea on how to resolve this bug ... scrap this code altogether. Looks like the code was unused forever. Can you prepare a patch for that please ? Best regards, Marek Vasut