[U-Boot] [common/cmd_ini.c:137]: (error) Uninitialized variable: line

[Wolfgang Denk <wd@denx.de>]

Dear Tom,

In message <20141106161600.GQ24724@bill-the-cat> you wrote:
> 
> trini at bill-the-cat:~/work/u-boot/u-boot-ti (master)$ cppcheck --version
> Cppcheck 1.52

-> cppcheck --version
Cppcheck 1.63

> trini at bill-the-cat:~/work/u-boot/u-boot-ti (master)$ cppcheck --force --inline-suppr common/cmd_ini.c
> Checking common/cmd_ini.c...
> Checking common/cmd_ini.c: CONFIG_INI_ALLOW_MULTILINE...
> Checking common/cmd_ini.c: CONFIG_INI_CASE_INSENSITIVE...
> Checking common/cmd_ini.c: CONFIG_INI_MAX_LINE...
> Checking common/cmd_ini.c: CONFIG_INI_MAX_NAME...
> Checking common/cmd_ini.c: CONFIG_INI_MAX_SECTION...

-> cppcheck --force --inline-suppr common/cmd_ini.c
Checking common/cmd_ini.c...
Checking common/cmd_ini.c: CONFIG_INI_ALLOW_MULTILINE...
Checking common/cmd_ini.c: CONFIG_INI_CASE_INSENSITIVE...
Checking common/cmd_ini.c: CONFIG_INI_MAX_LINE...
[common/cmd_ini.c:137]: (error) Uninitialized variable: line
Checking common/cmd_ini.c: CONFIG_INI_MAX_NAME...
Checking common/cmd_ini.c: CONFIG_INI_MAX_SECTION...

Same result with Cppcheck 1.67

> And I don't see anything.  I did this since manually inspecting things
> and the code looks correct here but I could see cppcheck failing to
> figure it out (and I could see the code being optimized, we pass line as
> a pointer but then also return that back..).

To me it looks as if it complained due to possibly incorrect
CONFIG_INI_MAX_LINE settings?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Put your Nose to the Grindstone!
                 -- Amalgamated Plastic Surgeons and Toolmakers, Ltd.