From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [net/eth.c:64]: (error) Uninitialized variable: skip_state
Date: Thu, 6 Nov 2014 13:52:39 -0500 [thread overview]
Message-ID: <20141106185239.GT24724@bill-the-cat> (raw)
In-Reply-To: <20141106181255.9A225382347@gemini.denx.de>
On Thu, Nov 06, 2014 at 07:12:55PM +0100, Wolfgang Denk wrote:
> Dear Tom Rini,
>
> In message <20141106164628.GR24724@bill-the-cat> you wrote:
> >
> > > [net/eth.c:64]: (error) Uninitialized variable: skip_state
> >
> > Dense code, like cmd_ini.c my cppcheck is OK and looking at the code
> > manually I think it's fine too:
> > return ((skip_state = getenv(enetvar)) != NULL);
>
> Looks OK to me, too, but recent versions of cppcheck spew this error.
File a bug back with them then? I do like what cppcheck is doing 'tho,
I poked some of the sandbox ones as well and they're real.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141106/1425dedb/attachment.pgp>
prev parent reply other threads:[~2014-11-06 18:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-06 12:37 [U-Boot] [net/eth.c:64]: (error) Uninitialized variable: skip_state Wolfgang Denk
2014-11-06 16:46 ` Tom Rini
2014-11-06 18:12 ` Wolfgang Denk
2014-11-06 18:52 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141106185239.GT24724@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox