[U-Boot] [PATCH 3/5] usb: s3c-otg: Split out PHY control

From: Lukasz Majewski <l.majewski@majess.pl>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/5] usb: s3c-otg: Split out PHY control
Date: Thu, 6 Nov 2014 22:29:03 +0100	[thread overview]
Message-ID: <20141106222903.33c33a3b@jawa> (raw)
In-Reply-To: <201411062123.46514.marex@denx.de>

On Thu, 6 Nov 2014 21:23:46 +0100
Marek Vasut <marex@denx.de> wrote:

> On Thursday, November 06, 2014 at 10:59:17 AM, Lukasz Majewski wrote:
> > Hi Marek,
> > 
> > > Split the Samsung specific PHY control into a separate file
> > > and compile this into the S3C OTG driver only if used on a
> > > Samsung system.
> > > 
> > > Signed-off-by: Marek Vasut <marex@denx.de>
> > > Cc: Chin Liang See <clsee@altera.com>
> > > Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
> > > Cc: Vince Bridgers <vbridger@altera.com>
> > > Cc: Pavel Machek <pavel@denx.de>
> > > Cc: Stefan Roese <sr@denx.de>
> > > Cc: Lukasz Majewski <l.majewski@samsung.com>
> 
> [...]
> 
> > Build HW: trats2 (Exynos4412)
> > 
> > CROSS_COMPILE=/home/lukma/work/ptxdist/toolchains/arm/OSELAS.Toolchain-2013
> > .12.0/arm-v7a-linux-gnueabi/gcc-4.8.2-glibc-2.18-binutils-2.24-kernel-3.12-
> > sanitized/bin/arm-v7a-linux-gnueabi-
> > 
> > Patches applied on top of v2014.10.
> 
> Try this trivial patch (add missing include):
> 
> diff --git a/drivers/usb/gadget/s3c_udc_otg_phy.c 
> b/drivers/usb/gadget/s3c_udc_otg_phy.c
> index 055fe86..95bd8cf 100644
> --- a/drivers/usb/gadget/s3c_udc_otg_phy.c
> +++ b/drivers/usb/gadget/s3c_udc_otg_phy.c
> @@ -35,6 +35,8 @@
>  #include "regs-otg.h"
>  #include <usb/lin_gadget_compat.h>
>  
> +#include <usb/s3c_udc.h>
> +

Ok, I will apply it and let you know about the result.

BTW: I assume that your work is to reuse the USB 2.0 UDC IP block
(probably in Altera).

I'd be elated if this is true :-).

>  void otg_phy_init(struct s3c_udc *dev)
>  {
>         unsigned int usb_phy_ctrl = dev->pdata->usb_phy_ctrl;
> 
> Best regards,
> Marek Vasut
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot

Best regards,
Lukasz Majewski
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141106/6d384fc0/attachment.pgp>