From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Date: Fri, 07 Nov 2014 09:59:25 +0100 Subject: [U-Boot] [PATCH 3/5] usb: s3c-otg: Split out PHY control In-Reply-To: <201411062126.01101.marex@denx.de> References: <1415077654-17181-1-git-send-email-marex@denx.de> <1415077654-17181-3-git-send-email-marex@denx.de> <20141104193421.GD13607@amd> <201411062126.01101.marex@denx.de> Message-ID: <20141107095925.703f631d@amdc2363> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Marek, > On Tuesday, November 04, 2014 at 08:34:21 PM, Pavel Machek wrote: > > On Tue 2014-11-04 06:07:32, Marek Vasut wrote: > > > Split the Samsung specific PHY control into a separate file > > > and compile this into the S3C OTG driver only if used on a > > > Samsung system. > > > > > > Signed-off-by: Marek Vasut > > > Cc: Chin Liang See > > > Cc: Dinh Nguyen > > > Cc: Vince Bridgers > > > > Acked-by: Pavel Machek > > > > I know you are just moving the code, but... > > > > > +void otg_phy_init(struct s3c_udc *dev) > > > +{ > > > + unsigned int usb_phy_ctrl = dev->pdata->usb_phy_ctrl; > > > + struct s3c_usbotg_phy *phy = > > > + (struct s3c_usbotg_phy *)dev->pdata->regs_phy; > > > + > > > + dev->pdata->phy_control(1); > > > + > > > + /*USB PHY0 Enable */ > > > > Wrong comment style. > > I'll fix this one. > > > > + printf("USB PHY0 Enable\n"); > > > + > > > + /* Enable PHY */ > > > + writel(readl(usb_phy_ctrl) | USB_PHY_CTRL_EN0, > > > usb_phy_ctrl); > > > > We have helpers for setting/clearing bits, right? > > Yes we do, Lukasz ... ? :) If you think about set_bit()/ clear_bit() functions from ./arch/arm/include/asm/bitops.h, then I don't mind to replace current code with them. Feel free to use them for next version of the patch. > > Best regards, > Marek Vasut -- Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group