From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Date: Fri, 07 Nov 2014 10:11:35 +0100 Subject: [U-Boot] [PATCH 4/5] usb: s3c-otg: Allow custom gusbcfg In-Reply-To: <201411062127.19394.marex@denx.de> References: <1415077654-17181-1-git-send-email-marex@denx.de> <1415077654-17181-4-git-send-email-marex@denx.de> <20141104193657.GE13607@amd> <201411062127.19394.marex@denx.de> Message-ID: <20141107101135.3b86a4f4@amdc2363> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Marek, > On Tuesday, November 04, 2014 at 08:36:57 PM, Pavel Machek wrote: > > On Tue 2014-11-04 06:07:33, Marek Vasut wrote: > > > Allow passing in a custom configuration of the gusbcfg register > > > via platform data. > > > > > > Signed-off-by: Marek Vasut > > > Cc: Chin Liang See > > > Cc: Dinh Nguyen > > > Cc: Vince Bridgers > > > > Acked-by: Pavel Machek > > > > > debug("Reseting OTG controller\n"); > > > > > > - writel(0<<15 /* PHY Low Power Clock sel*/ > > > + dflt_gusbcfg = > > > + 0<<15 /* PHY Low Power Clock sel*/ > > > > > > |1<<14 /* Non-Periodic TxFIFO > > > Rewind Enable*/ |0x5<<10 /* Turnaround time*/ > > > |0<<9 | 0<<8 /* [0:HNP disable,1:HNP > > > enable][ 0:SRP disable*/ > > > > > > @@ -413,8 +415,12 @@ static void reconfig_usbd(void) > > > > > > |0<<6 /* 0: high speed utmi+, 1: > > > full speed serial*/ |0<<4 /* 0: utmi+, 1:ulpi*/ > > > |1<<3 /* phy i/f 0:8bit, > > > 1:16bit*/ > > > > > > - |0x7<<0, /* HS/FS Timeout**/ > > > - ®->gusbcfg); > > > + |0x7<<0; /* HS/FS Timeout**/ > > > + > > > > "Interesting" comment style. And I'd remove 0x prefixes from > > constants <8... > > Lukasz, what do you say to just convert those four boards to use the > gusbcfg platform data afterward ? +1 It is a very good idea since we are using the same dwc2 IP block for host (./usb/host/dwc2.c) and device (s3c_hsotg). > > btw. you can find the latest version in u-boot-usb:topic/s3c-otg I've read comments from Pavel and tested the code up till first build error :-). > > Best regards, > Marek Vasut -- Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group