[U-Boot] [PATCH v3 3/3] imx:mx6slevk add board level support for usb

Marek Vasut
2014-11-07T08:26:09Z

On Friday, November 07, 2014 at 02:08:14 AM, Peng Fan wrote:
> Add pinmux settings, implement board_ehci_hcd_init, board_usb_phy_mode
>
> There are two usb port on mx6slevk board:
> 1. otg port
> 2. host port
> The following are the connection between usb controller and board usb
> interface, host port has not ID pin set:
> otg1 core <---> board otg port
> otg2 core <---> board host port
> In order to make host port work, board_usb_phy_mode return 0 to let
> ehci-mx6.c driver decide otg2 core to works in host mode.
>
> Signed-off-by: Peng Fan <Peng.Fan@freescale.com>
> Signed-off-by: Ye Li <B37916@freescale.com>
> ---

[...]

> @@ -150,6 +151,63 @@ static int setup_fec(void)
> }
> #endif
>
> +#ifdef CONFIG_USB_EHCI_MX6
> +#define USB_OTHERREGS_OFFSET 0x800
> +#define USBPHY_CTRL 0x30
> +#define UCTRL_PWR_POL (1 << 9)
> +#define USBPHY_CTRL_OTG_ID 0x08000000

This looks like an duplication. Aren't those bits defined somewhere in
generic code already ?
[...]
Best regards,
Marek Vasut