From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Date: Mon, 10 Nov 2014 11:47:58 +0100 Subject: [U-Boot] [PATCH 2/4 v4] arm: socfpga: dts: Add Cadence QSPI DT node to socfpga.dtsi In-Reply-To: <545D00AD.6080105@denx.de> References: <1415360272-13249-1-git-send-email-sr@denx.de> <1415360272-13249-3-git-send-email-sr@denx.de> <545D00AD.6080105@denx.de> Message-ID: <20141110104758.GA27292@amd> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Fri 2014-11-07 18:26:05, Stefan Roese wrote: > Hi Simon, > > On 07.11.2014 18:21, Simon Glass wrote: > >>+ qspi: spi at ff705000 { > >>+ compatible = "cadence,qspi"; > >>+ #address-cells = <1>; > >>+ #size-cells = <0>; > >>+ reg = <0xff705000 0x1000>, > >>+ <0xffa00000 0x1000>; > >>+ interrupts = <0 151 4>; > >>+ clocks = <&qspi_clk>; > >>+ ext-decoder = <0>; /* external decoder */ > >>+ num-chipselect = <4>; > >>+ fifo-depth = <128>; > >>+ bus-num = <2>; > >>+ status = "disabled"; > >>+ }; > >>+ > > > >Is this the same binding as Linux? Can you please bring in the binding > >document too? Some of these feel like they should have a > >"manufacture," prefix. > > Yes, its from Linux. But not from kernel.org but from the Altera > Rocketboards.org version (v3.16). So the bindings might change if this > driver would be pushed to mainline Linux. I guess it would be good to submit the binding to Linux for review, so that we don't end up with two incompatible bindings... Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html