public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 1/3] usb:ehci-mx6 add board_usb_phy_mode function
Date: Mon, 10 Nov 2014 18:55:26 +0100	[thread overview]
Message-ID: <201411101855.26694.marex@denx.de> (raw)
In-Reply-To: <54600E7E.5@freescale.com>

On Monday, November 10, 2014 at 02:01:50 AM, Peng Fan wrote:
[...]
> >> +
> >> in usb_phy_mode, query a PHY for it's mode.
> >> 
> >> And righter after usb_phy_enable in ehci-mx6.c.
> >> -       type = usb_phy_enable(index, ehci) ? USB_INIT_DEVICE :
> >> USB_INIT_HOST;
> >> +       usb_phy_enable(index, ehci);
> >> +       type = usb_phy_mode(index);
> >> 
> >> usb_phy_enable return 0 but not return val & USBPHY_CTRL_OTG_ID. There
> >> is no status bit for query enabled or not, so just return 0.
> >> 
> >> In board file:
> >> int board_usb_phy_mode(int port)
> >> {
> >> 
> >>           if (port == 1)
> >>           
> >>                   return USB_INIT_HOST;
> >>           
> >>           else
> >>           
> >>                   return usb_phy_mode(port);
> >> 
> >> }
> >> 
> >> I think this is better way then previous patch, but i did not find where
> >> to put the usb_phy_mode prototype type, since board file will use it.
> > 
> > Looks OK otherwise.
> 
> Sent out v4 patch, please review.

Thanks! Will do as time permits. Sorry for possible delays.

Best regards,
Marek Vasut

  reply	other threads:[~2014-11-10 17:55 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-07  1:08 [U-Boot] [PATCH v3 0/3] Add board level usb supporrt for mxsxsabresd and mx6slevk Peng Fan
2014-11-07  1:08 ` [U-Boot] [PATCH v3 1/3] usb:ehci-mx6 add board_usb_phy_mode function Peng Fan
2014-11-07  8:25   ` Marek Vasut
2014-11-07 11:03     ` Peng Fan
2014-11-07 11:09       ` Marek Vasut
2014-11-07 11:45         ` Peng Fan
2014-11-07 12:17           ` Marek Vasut
2014-11-08  4:07             ` Peng Fan
2014-11-08  4:35               ` Peng Fan
2014-11-08 11:33               ` Marek Vasut
2014-11-10  1:01                 ` Peng Fan
2014-11-10 17:55                   ` Marek Vasut [this message]
2014-11-07  1:08 ` [U-Boot] [PATCH v3 2/3] imx:mx6sxsabresd add board level support for usb Peng Fan
2014-11-07  1:08 ` [U-Boot] [PATCH v3 3/3] imx:mx6slevk " Peng Fan
2014-11-07  8:26   ` Marek Vasut
2014-11-07 11:08     ` Peng Fan
2014-11-07 11:10       ` Marek Vasut
2014-11-07 11:48         ` Peng Fan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201411101855.26694.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox