public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, 1/6] dlmalloc: ensure gd is set for early alloc
Date: Mon, 10 Nov 2014 16:26:47 -0500	[thread overview]
Message-ID: <20141110212647.GR24724@bill-the-cat> (raw)
In-Reply-To: <1414621302-32062-1-git-send-email-rabin@rab.in>

On Wed, Oct 29, 2014 at 11:21:37PM +0100, Rabin Vincent wrote:

> Attempting to run the sandbox leads to a segfault, because some dynamic
> libraries (outside of u-boot) attempt to use malloc() to allocate memory
> before u-boot's gd variable is initialized.
> 
> Check for gd not being NULL in the SYS_MALLOC_F_LEN handling, so that
> malloc() doesn't crash when called at this point.
> 
>  $ gdb -q --args ./u-boot
>  (gdb) r
>  Program received signal SIGSEGV, Segmentation fault.
>  0x0000000000412b9b in malloc (bytes=bytes at entry=37) at common/dlmalloc.c:2184
>  2184		if (!(gd->flags & GD_FLG_RELOC)) {
>  (gdb) p gd
>  $1 = (gd_t *) 0x0
>  (gdb) bt
>  #0  0x0000000000412b9b in malloc (bytes=bytes at entry=37) at common/dlmalloc.c:2184
>  #1  0x00007ffff75bf8e1 in set_binding_values (domainname=0x7ffff11f4f12 "libgpg-error", dirnamep=0x7fffffffe168, codesetp=0x0)
>      at bindtextdom.c:228
>  #2  0x00007ffff75bfb4c in set_binding_values (codesetp=0x0, dirnamep=0x7fffffffe168, domainname=<optimized out>) at bindtextdom.c:350
>  #3  __bindtextdomain (domainname=<optimized out>, dirname=0x7ffff11f4f00 "/usr/share/locale") at bindtextdom.c:348
>  #4  0x00007ffff11eca17 in ?? () from /lib/x86_64-linux-gnu/libgpg-error.so.0
>  #5  0x00007ffff7dea9fa in call_init (l=<optimized out>, argc=argc at entry=1, argv=argv at entry=0x7fffffffe208,
>      env=env at entry=0x7fffffffe218) at dl-init.c:78
>  #6  0x00007ffff7deaae3 in call_init (env=0x7fffffffe218, argv=0x7fffffffe208, argc=1, l=<optimized out>) at dl-init.c:36
>  #7  _dl_init (main_map=0x7ffff7ffe1a8, argc=1, argv=0x7fffffffe208, env=0x7fffffffe218) at dl-init.c:126
>  #8  0x00007ffff7ddd1ca in _dl_start_user () from /lib64/ld-linux-x86-64.so.2
> 
> Signed-off-by: Rabin Vincent <rabin@rab.in>
> Acked-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141110/72127b2f/attachment.pgp>

      parent reply	other threads:[~2014-11-10 21:26 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-29 22:21 [U-Boot] [PATCH 1/6] dlmalloc: ensure gd is set for early alloc Rabin Vincent
2014-10-29 22:21 ` [U-Boot] [PATCH 2/6] sandbox: init cli for -c Rabin Vincent
2014-11-01 15:11   ` Simon Glass
2014-11-10 21:26   ` [U-Boot] [U-Boot,2/6] " Tom Rini
2014-10-29 22:21 ` [U-Boot] [PATCH 3/6] hush: return consistent codes from run_command() Rabin Vincent
2014-11-01 15:11   ` Simon Glass
2014-11-10 21:26   ` [U-Boot] [U-Boot, " Tom Rini
2014-10-29 22:21 ` [U-Boot] [PATCH 4/6] hush: fix segfault on syntax error Rabin Vincent
2014-11-01 15:11   ` Simon Glass
2014-11-10 21:27   ` [U-Boot] [U-Boot,4/6] " Tom Rini
2014-10-29 22:21 ` [U-Boot] [PATCH 5/6] hush: make run_command() return an error on parsing failure Rabin Vincent
2014-11-01 15:12   ` Simon Glass
2014-11-10 21:27   ` [U-Boot] [U-Boot, " Tom Rini
2014-10-29 22:21 ` [U-Boot] [PATCH 6/6] hush: add some tests for quoting Rabin Vincent
2014-11-01 15:12   ` Simon Glass
2014-11-05 20:11     ` Rabin Vincent
2014-11-06 19:26       ` Simon Glass
2014-11-01 15:11 ` [U-Boot] [PATCH 1/6] dlmalloc: ensure gd is set for early alloc Simon Glass
2014-11-05 19:37   ` Rabin Vincent
2014-11-10 21:26 ` Tom Rini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141110212647.GR24724@bill-the-cat \
    --to=trini@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox