[U-Boot] [PATCH 6/6] arm: socfpga: Add Designware (DW) SPI support to config header

Marek Vasut
2014-11-14T20:18:04Z

On Wednesday, November 12, 2014 at 06:53:54 PM, Pavel Machek wrote:
> On Fri 2014-11-07 13:50:34, Stefan Roese wrote:
> > Enable support for the DW master SPI controller in the config header
> > for the SoCFPGA. This controller can only be enabled, if DT support
> > is enabled.
> >
> > Signed-off-by: Stefan Roese <sr@denx.de>
> > Cc: Chin Liang See <clsee@altera.com>
> > Cc: Dinh Nguyen <dinguyen@altera.com>
> > Cc: Vince Bridgers <vbridger@altera.com>
> > Cc: Marek Vasut <marex@denx.de>
> > Cc: Pavel Machek <pavel@denx.de>
> > ---
> >
> > include/configs/socfpga_common.h | 12 ++++++++++++
> > 1 file changed, 12 insertions(+)
> >
> > diff --git a/include/configs/socfpga_common.h
> > b/include/configs/socfpga_common.h index 9fc4212..830b956 100644
> > --- a/include/configs/socfpga_common.h
> > +++ b/include/configs/socfpga_common.h
> > @@ -191,6 +191,18 @@ unsigned int cm_get_qspi_controller_clk_hz(void);
> >
> > #define CONFIG_CMD_SF
> > #endif
> >
> > +#ifdef CONFIG_OF_CONTROL /* DW SPI is controlled via DT */
> > +#define CONFIG_CMD_DM
> > +#define CONFIG_DM
> > +#define CONFIG_DM_SPI
> > +#define CONFIG_DESIGNWARE_SPI
> > +#ifndef __ASSEMBLY__
> > +unsigned int cm_get_spi_controller_clk_hz(void);
> > +#define CONFIG_DW_SPI_REF_CLK cm_get_spi_controller_clk_hz()
>
> Putting prototypes into configuration file is ugly. Hiding function
> call into macro so that it looks like constant is evil. Is there
> better solution?

The SPI driver should call this function directly. Or is there a reason why
such a macro is used ?

Best regards,
Marek Vasut