public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] arm: socfpga: set skew settings for ethernet phy
Date: Thu, 13 Nov 2014 13:20:52 +0100	[thread overview]
Message-ID: <20141113122052.967EB382304@gemini.denx.de> (raw)
In-Reply-To: <20141113120956.GB30779@amd>

Dear Pavel Machek,

In message <20141113120956.GB30779@amd> you wrote:
> 
> diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
> index 507b9a3..06a31b0 100644
> --- a/drivers/net/phy/micrel.c
> +++ b/drivers/net/phy/micrel.c
> @@ -112,17 +112,46 @@ static int ksz9021_phy_extwrite(struct phy_device *phydev, int addr,
>  	return ksz9021_phy_extended_write(phydev, regnum, val);
>  }
>  
> +
> +

Please don't add excessive white space / blank lines.

> +	printf("ksz9021: configuring\n");
> +
> +	printf("Configuring PHY skew timing for %s\n",
> +	       phydev->drv->name);

Should these eventually be changed into debug() ?

Output gets really noisy otherwise.

>  	if (getenv("disable_giga"))

Should we not rather use the standard "hwconf" approach here?


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There is a time in the tides of men, Which, taken at its flood, leads
on to success. On the other hand, don't count on it.   - T. K. Lawson

  reply	other threads:[~2014-11-13 12:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-11 20:45 [U-Boot] arm: socfpga: set skew settings for ethernet phy dinguyen at opensource.altera.com
2014-11-13 12:09 ` Pavel Machek
2014-11-13 12:20   ` Wolfgang Denk [this message]
2014-11-13 12:25     ` Pavel Machek
2014-11-13 12:32       ` Albert ARIBAUD
2014-11-13 12:48         ` Pavel Machek
2014-11-13 13:02           ` Marek Vasut
2014-11-25 11:14             ` [U-Boot] arm: socfpga: script for installing u-boot / u-boot-SPL Pavel Machek
2014-11-25 15:28               ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141113122052.967EB382304@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox