From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Thu, 13 Nov 2014 12:31:52 +0100 Subject: [U-Boot] [PATCH v3 01/14] arm: spl: Avoid setting up a duplicate global data structure In-Reply-To: <1415665015-12651-2-git-send-email-sjg@chromium.org> References: <1415665015-12651-1-git-send-email-sjg@chromium.org> <1415665015-12651-2-git-send-email-sjg@chromium.org> Message-ID: <20141113123152.4828396e@lilith> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Simon, On Mon, 10 Nov 2014 17:16:41 -0700, Simon Glass wrote: > This is already set up in crt0.S. We don't need a new structure and don't > really want one in the 'data' section of the image, since it will be empty > and crt0.S's changes will be ignored. > > Signed-off-by: Simon Glass > --- > > Changes in v3: None > Changes in v2: None > > arch/arm/lib/spl.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/arch/arm/lib/spl.c b/arch/arm/lib/spl.c > index 75ab546..6361a62 100644 > --- a/arch/arm/lib/spl.c > +++ b/arch/arm/lib/spl.c > @@ -13,10 +13,6 @@ > #include > #include > > -/* Pointer to as well as the global data structure for SPL */ > -DECLARE_GLOBAL_DATA_PTR; > -gd_t gdata __attribute__ ((section(".data"))); > - > /* > * In the context of SPL, board_init_f must ensure that any clocks/etc for > * DDR are enabled, ensure that the stack pointer is valid, clear the BSS > -- > 2.1.0.rc2.206.gedb03e5 > Acked-by: Albert ARIBAUD Amicalement, -- Albert.