From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 22/30] ARM: cache_v7: Various minor cleanups
Date: Fri, 14 Nov 2014 09:00:26 +0100 [thread overview]
Message-ID: <20141114090026.066ff35f@lilith> (raw)
In-Reply-To: <1415842036-28471-23-git-send-email-sjg@chromium.org>
Hello Simon,
I've actually applied v2 of this patch and PRed it to u-boot/master)
and accidentally not acked it.
Apologies.
On Wed, 12 Nov 2014 18:27:08 -0700, Simon Glass <sjg@chromium.org>
wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> Remove two gratuituous blank lines, uses u32 (instead of int) as the
> type for values that will be written to a register, moves the beginning
> of the variable declaration section to a separate line (rather than the
> one with the opening brace) and keeps the function signature on a single
> line where possible.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> Acked-by: Simon Glass <sjg@chromium.org>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
> Changes in v3: None
>
> arch/arm/cpu/armv7/cache_v7.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm/cpu/armv7/cache_v7.c b/arch/arm/cpu/armv7/cache_v7.c
> index a2c4032..0f9d837 100644
> --- a/arch/arm/cpu/armv7/cache_v7.c
> +++ b/arch/arm/cpu/armv7/cache_v7.c
> @@ -21,7 +21,8 @@
> * to get size details from Current Cache Size ID Register(CCSIDR)
> */
> static void set_csselr(u32 level, u32 type)
> -{ u32 csselr = level << 1 | type;
> +{
> + u32 csselr = level << 1 | type;
>
> /* Write to Cache Size Selection Register(CSSELR) */
> asm volatile ("mcr p15, 2, %0, c0, c0, 0" : : "r" (csselr));
> @@ -49,7 +50,8 @@ static void v7_inval_dcache_level_setway(u32 level, u32 num_sets,
> u32 num_ways, u32 way_shift,
> u32 log2_line_len)
> {
> - int way, set, setway;
> + int way, set;
> + u32 setway;
>
> /*
> * For optimal assembly code:
> @@ -73,7 +75,8 @@ static void v7_clean_inval_dcache_level_setway(u32 level, u32 num_sets,
> u32 num_ways, u32 way_shift,
> u32 log2_line_len)
> {
> - int way, set, setway;
> + int way, set;
> + u32 setway;
>
> /*
> * For optimal assembly code:
> @@ -134,7 +137,6 @@ static void v7_maint_dcache_level_setway(u32 level, u32 operation)
> static void v7_maint_dcache_all(u32 operation)
> {
> u32 level, cache_type, level_start_bit = 0;
> -
> u32 clidr = get_clidr();
>
> for (level = 0; level < 7; level++) {
> @@ -147,8 +149,7 @@ static void v7_maint_dcache_all(u32 operation)
> }
> }
>
> -static void v7_dcache_clean_inval_range(u32 start,
> - u32 stop, u32 line_len)
> +static void v7_dcache_clean_inval_range(u32 start, u32 stop, u32 line_len)
> {
> u32 mva;
>
> @@ -256,7 +257,6 @@ void flush_dcache_all(void)
> */
> void invalidate_dcache_range(unsigned long start, unsigned long stop)
> {
> -
> v7_dcache_maint_range(start, stop, ARMV7_DCACHE_INVAL_RANGE);
>
> v7_outer_cache_inval_range(start, stop);
> --
> 2.1.0.rc2.206.gedb03e5
>
Amicalement,
--
Albert.
next prev parent reply other threads:[~2014-11-14 8:00 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 1:26 [U-Boot] [PATCH v3 0/30] ARM: tegra: Add PCIe support Simon Glass
2014-11-13 1:26 ` [U-Boot] [PATCH v3 01/30] vsprintf: Add modifier for phys_addr_t Simon Glass
2014-11-17 10:18 ` Thierry Reding
2014-11-17 18:31 ` Simon Glass
2014-11-24 22:11 ` [U-Boot] [U-Boot, v3, " Tom Rini
2014-11-13 1:26 ` [U-Boot] [PATCH v3 02/30] pci: Abort early if bus does not exist Simon Glass
2014-11-24 22:11 ` [U-Boot] [U-Boot, v3, " Tom Rini
2014-11-13 1:26 ` [U-Boot] [PATCH v3 03/30] pci: Honour pci_skip_dev() Simon Glass
2014-11-24 22:11 ` [U-Boot] [U-Boot,v3,03/30] " Tom Rini
2014-11-13 1:26 ` [U-Boot] [PATCH v3 04/30] Add pr_fmt() macro Simon Glass
2014-11-24 22:11 ` [U-Boot] [U-Boot,v3,04/30] " Tom Rini
2014-11-13 1:26 ` [U-Boot] [PATCH v3 05/30] power: Add AMS AS3722 PMIC support Simon Glass
2014-11-17 10:04 ` Thierry Reding
2014-11-17 18:30 ` Simon Glass
2014-11-13 1:26 ` [U-Boot] [PATCH v3 06/30] ARM: tegra: Implement tegra_plle_enable() Simon Glass
2014-11-13 1:26 ` [U-Boot] [PATCH v3 07/30] ARM: tegra: Provide PCIEXCLK reset ID Simon Glass
2014-11-13 1:26 ` [U-Boot] [PATCH v3 08/30] ARM: tegra: Implement powergate support Simon Glass
2014-11-13 1:26 ` [U-Boot] [PATCH v3 09/30] ARM: tegra: Implement XUSB pad controller Simon Glass
2014-11-13 1:26 ` [U-Boot] [PATCH v3 10/30] ARM: tegra: Add XUSB pad controller on Tegra124 Simon Glass
2014-11-13 1:26 ` [U-Boot] [PATCH v3 11/30] ARM: tegra: Enable XUSB pad controller on Jetson TK1 Simon Glass
2014-11-13 1:26 ` [U-Boot] [PATCH v3 12/30] pci: tegra: Add Tegra PCIe driver Simon Glass
2014-11-13 1:26 ` [U-Boot] [PATCH v3 13/30] ARM: tegra: Add Tegra20 PCIe device tree node Simon Glass
2014-11-13 1:27 ` [U-Boot] [PATCH v3 14/30] ARM: tegra: Enable PCIe on TrimSlice Simon Glass
2014-11-13 1:27 ` [U-Boot] [PATCH v3 15/30] ARM: tegra: Add GIC for Tegra30 Simon Glass
2014-11-13 1:27 ` [U-Boot] [PATCH v3 16/30] ARM: tegra: Add Tegra30 PCIe device tree node Simon Glass
2014-11-13 1:27 ` [U-Boot] [PATCH v3 17/30] ARM: tegra: Enable PCIe on Cardhu Simon Glass
2014-11-13 1:27 ` [U-Boot] [PATCH v3 18/30] ARM: tegra: Enable PCIe on Beaver Simon Glass
2014-11-13 1:27 ` [U-Boot] [PATCH v3 19/30] ARM: tegra: Add GIC for Tegra124 Simon Glass
2014-11-13 1:27 ` [U-Boot] [PATCH v3 20/30] ARM: tegra: Add Tegra124 PCIe device tree node Simon Glass
2014-11-13 1:27 ` [U-Boot] [PATCH v3 21/30] ARM: tegra: Enable PCIe on Jetson TK1 Simon Glass
2014-11-13 1:27 ` [U-Boot] [PATCH v3 22/30] ARM: cache_v7: Various minor cleanups Simon Glass
2014-11-14 8:00 ` Albert ARIBAUD [this message]
2014-11-15 1:54 ` Simon Glass
2014-11-13 1:27 ` [U-Boot] [PATCH v3 23/30] ARM: cache-cp15: Use more accurate types Simon Glass
2014-11-14 8:00 ` Albert ARIBAUD
2014-11-13 1:27 ` [U-Boot] [PATCH v3 24/30] malloc: Output region when debugging Simon Glass
2014-11-24 22:11 ` [U-Boot] [U-Boot, v3, " Tom Rini
2014-11-13 1:27 ` [U-Boot] [PATCH v3 25/30] ARM: Implement non-cached memory support Simon Glass
2014-11-13 1:27 ` [U-Boot] [PATCH v3 26/30] ARM: tegra: Enable non-cached memory Simon Glass
2014-11-13 1:27 ` [U-Boot] [PATCH v3 27/30] net: rtl8169: Honor CONFIG_SYS_RX_ETH_BUFFER Simon Glass
2014-11-13 1:27 ` [U-Boot] [PATCH v3 28/30] net: rtl8169: Properly align buffers Simon Glass
2014-11-13 1:27 ` [U-Boot] [PATCH v3 29/30] net: rtl8169: Use non-cached memory if available Simon Glass
2014-11-17 10:16 ` Thierry Reding
2014-11-13 1:27 ` [U-Boot] [PATCH v3 30/30] net: rtl8169: Add support for RTL-8168/8111g Simon Glass
2014-11-17 10:14 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141114090026.066ff35f@lilith \
--to=albert.u.boot@aribaud.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox