[U-Boot] [PATCH 3/6] sunxi: video: Add cfb console driver for sunxi

Anatolij Gustschin
2014-11-14T20:17:39Z

Hi Hans,

this patch looks good, only a few minor comments below.

On Fri, 14 Nov 2014 17:54:45 +0100
Hans de Goede <hdegoede@redhat.com> wrote:
...
> diff --git a/arch/arm/include/asm/arch-sunxi/display.h b/arch/arm/include/asm/arch-sunxi/display.h
> new file mode 100644
> index 0000000..8ac7d1b
> --- /dev/null
> +++ b/arch/arm/include/asm/arch-sunxi/display.h
> @@ -0,0 +1,198 @@
> +/*
> + * Sunxi platform display cntroller register and constant defines

s/cntroller/controller/

not need to resubmit the patch, this can be fixed when applying.

...
> +#if 1
> + printf("dotclock: %dkHz = %dkHz: (%d * 3MHz * %d) / %d\n",
> + dotclock, (best_double + 1) * 3000 * best_n / best_m,
> + best_double + 1, best_n, best_m);
> +#endif

please drop #if 1 / #endif when applying the patch.
here, printf() could be replaced by debug() maybe ?

...
> + udelay(1000000 / mode->refresh + 500);
> +
> + /* Sometimes the display pipeline does not sync up properly, if
> + this happens the hdmi fifo underrun or overrun bits are set */

we use

/*
* multi-line
* comment
*/

style.

Thanks,

Anatolij