From: Pavel Machek <pavel@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] arm: socfpga: set skew settings for ethernet phy
Date: Sat, 15 Nov 2014 20:54:06 +0100 [thread overview]
Message-ID: <20141115195406.GA9677@amd> (raw)
In-Reply-To: <201411142102.48950.marex@denx.de>
On Fri 2014-11-14 21:02:48, Marek Vasut wrote:
> On Friday, November 14, 2014 at 11:23:27 AM, Pavel Machek wrote:
> > On Thu 2014-11-13 11:23:41, dinguyen at opensource.altera.com wrote:
> > > From: Dinh Nguyen <dinguyen@opensource.altera.com>
> > >
> > > Set the PHY skew settings for the ethernet phy on the SOCFPGA Cyclone5
> > > hardware.
> >
> > Is it to need similar settings for all ksz9021 phys? Should this go to
> > drivers/ as I suggested with a patch?
> >
>
> This is board specific, but with the driver model, this should be moved into the
> PHY driver and the values should be passed via platform data or DT.
>
> I will apply this now, since it fixes real issue.
Hmm, could you apply the patch I posted, instead? It has configuration
in socfpga_config.h -- "platform data".
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2014-11-15 19:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 17:23 [U-Boot] [PATCH v2] arm: socfpga: set skew settings for ethernet phy dinguyen at opensource.altera.com
2014-11-14 10:23 ` Pavel Machek
2014-11-14 20:02 ` Marek Vasut
2014-11-15 19:54 ` Pavel Machek [this message]
2014-11-15 21:29 ` Marek Vasut
2014-11-15 22:20 ` Pavel Machek
2014-11-15 23:36 ` Marek Vasut
2014-11-14 20:06 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141115195406.GA9677@amd \
--to=pavel@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox