From: Pavel Machek <pavel@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/5] arm: socfpga: Use only one clrbits_le32 call to deassert SPI reset bits
Date: Mon, 17 Nov 2014 08:54:56 +0100 [thread overview]
Message-ID: <20141117075456.GB15909@amd> (raw)
In-Reply-To: <1416138422-9556-2-git-send-email-sr@denx.de>
On Sun 2014-11-16 12:46:59, Stefan Roese wrote:
> As suggested by Pavel, lets combine the two calls into one.
>
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Chin Liang See <clsee@altera.com>
> Cc: Dinh Nguyen <dinguyen@altera.com>
> Cc: Vince Bridgers <vbridger@altera.com>
> Cc: Marek Vasut <marex@denx.de>
Acked-by: Pavel Machek <pavel@denx.de>
> ---
> arch/arm/cpu/armv7/socfpga/reset_manager.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/cpu/armv7/socfpga/reset_manager.c b/arch/arm/cpu/armv7/socfpga/reset_manager.c
> index af9db85..25921e7 100644
> --- a/arch/arm/cpu/armv7/socfpga/reset_manager.c
> +++ b/arch/arm/cpu/armv7/socfpga/reset_manager.c
> @@ -110,6 +110,6 @@ void socfpga_spim_enable(void)
> {
> const void *reset = &reset_manager_base->per_mod_reset;
>
> - clrbits_le32(reset, 1 << RSTMGR_PERMODRST_SPIM0_LSB);
> - clrbits_le32(reset, 1 << RSTMGR_PERMODRST_SPIM1_LSB);
> + clrbits_le32(reset, (1 << RSTMGR_PERMODRST_SPIM0_LSB) |
> + (1 << RSTMGR_PERMODRST_SPIM1_LSB));
> }
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2014-11-17 7:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-16 11:46 [U-Boot] [PATCH 1/5] arm: socfpga: dts: altr, rst-mgr.h: Move to SPDX license identifiers Stefan Roese
2014-11-16 11:46 ` [U-Boot] [PATCH 2/5] arm: socfpga: Use only one clrbits_le32 call to deassert SPI reset bits Stefan Roese
2014-11-17 7:54 ` Pavel Machek [this message]
2014-11-16 11:47 ` [U-Boot] [PATCH 3/5] arm: socfpga: Add missing DW master SPI clock prototyp to clock_manager.h Stefan Roese
2014-11-17 7:55 ` Pavel Machek
2014-11-16 11:47 ` [U-Boot] [PATCH 4/5] spi: designware_spi: Some fixes / changes Stefan Roese
2014-11-17 7:56 ` Pavel Machek
2014-11-16 11:47 ` [U-Boot] [PATCH 5/5] arm: socfpga: DW_SPI: Remove clock info from config header Stefan Roese
2014-11-17 7:56 ` Pavel Machek
2014-11-17 7:54 ` [U-Boot] [PATCH 1/5] arm: socfpga: dts: altr, rst-mgr.h: Move to SPDX license identifiers Pavel Machek
2014-11-19 22:36 ` Marek Vasut
2014-11-20 7:21 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141117075456.GB15909@amd \
--to=pavel@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox