From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Date: Mon, 17 Nov 2014 11:04:43 +0100 Subject: [U-Boot] [PATCH v3 05/30] power: Add AMS AS3722 PMIC support In-Reply-To: <1415842036-28471-6-git-send-email-sjg@chromium.org> References: <1415842036-28471-1-git-send-email-sjg@chromium.org> <1415842036-28471-6-git-send-email-sjg@chromium.org> Message-ID: <20141117100442.GC20092@ulmo.nvidia.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, Nov 12, 2014 at 06:26:51PM -0700, Simon Glass wrote: [...] > diff --git a/drivers/power/as3722.c b/drivers/power/as3722.c [...] > +int as3722_init(struct udevice **devp) > +{ > + struct udevice *pmic; > + u8 id, revision; > + int bus = 0; > + int address = 0x40; Is there a reason for bus and address to not be unsigned? I also take it that the plan is to eventually query these from the udevice/DT once I2C has been converted to DM? Thierry -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 819 bytes Desc: not available URL: