[U-Boot] [PATCH v3 05/30] power: Add AMS AS3722 PMIC support

Simon Glass
2014-11-17T18:30:19Z

Hi Thierry,

On 17 November 2014 10:04, Thierry Reding <treding@nvidia.com> wrote:
> On Wed, Nov 12, 2014 at 06:26:51PM -0700, Simon Glass wrote:
> [...]
>> diff --git a/drivers/power/as3722.c b/drivers/power/as3722.c
> [...]
>> +int as3722_init(struct udevice **devp)
>> +{
>> + struct udevice *pmic;
>> + u8 id, revision;
>> + int bus = 0;
>> + int address = 0x40;
>
> Is there a reason for bus and address to not be unsigned? I also take it
> that the plan is to eventually query these from the udevice/DT once I2C
> has been converted to DM?

They can be unsigned but I didn't think it was important. They should
probably be const too...

This does in fact use DM for I2C - I place this series on top of the
I2C series. I'm going to give it a few more days for people like
you/Tom/Stephen to take a look at the Tegra DM conversion for I2C,
then I'll bring it through the DM tree, and likely this series too,
after fixing the nits.

The near-term plan is to use the PMIC support when it moves to DM. But
for now this is pretty clean.

Regards,
Simon