public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] usb: ehci: do not set the LSB of Current qTD pointer
@ 2014-11-17  8:54 Masahiro Yamada
  2014-11-19 22:32 ` Marek Vasut
  0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2014-11-17  8:54 UTC (permalink / raw)
  To: u-boot

According to EHCI specification, the LSB of DWORD 3 of Queue Head
(Current qTD Pointer) is not T-bit, but always zero.

Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
---

 drivers/usb/host/ehci-hcd.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
index c671c72..54e948a 100644
--- a/drivers/usb/host/ehci-hcd.c
+++ b/drivers/usb/host/ehci-hcd.c
@@ -971,7 +971,6 @@ int usb_lowlevel_init(int index, enum usb_init_type init, void **controller)
 	qh_list->qh_link = cpu_to_hc32((uint32_t)qh_list | QH_LINK_TYPE_QH);
 	qh_list->qh_endpt1 = cpu_to_hc32(QH_ENDPT1_H(1) |
 						QH_ENDPT1_EPS(USB_SPEED_HIGH));
-	qh_list->qh_curtd = cpu_to_hc32(QT_NEXT_TERMINATE);
 	qh_list->qh_overlay.qt_next = cpu_to_hc32(QT_NEXT_TERMINATE);
 	qh_list->qh_overlay.qt_altnext = cpu_to_hc32(QT_NEXT_TERMINATE);
 	qh_list->qh_overlay.qt_token =
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [U-Boot] [PATCH] usb: ehci: do not set the LSB of Current qTD pointer
  2014-11-17  8:54 [U-Boot] [PATCH] usb: ehci: do not set the LSB of Current qTD pointer Masahiro Yamada
@ 2014-11-19 22:32 ` Marek Vasut
  0 siblings, 0 replies; 2+ messages in thread
From: Marek Vasut @ 2014-11-19 22:32 UTC (permalink / raw)
  To: u-boot

On Monday, November 17, 2014 at 09:54:14 AM, Masahiro Yamada wrote:
> According to EHCI specification, the LSB of DWORD 3 of Queue Head
> (Current qTD Pointer) is not T-bit, but always zero.
> 
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>

Applied, thanks!

Best regards,
Marek Vasut

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-11-19 22:32 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-17  8:54 [U-Boot] [PATCH] usb: ehci: do not set the LSB of Current qTD pointer Masahiro Yamada
2014-11-19 22:32 ` Marek Vasut

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox