From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Fri, 21 Nov 2014 16:30:59 +0100 Subject: [U-Boot] [PATCH] fix: tools: kwbimage.c: Initialize headersz to suppress warning In-Reply-To: <546F3161.1040906@myspectrum.nl> References: <1416558163-23614-1-git-send-email-l.majewski@samsung.com> <20141121093514.5166e9fd@free-electrons.com> <20141121102026.75aad6e2@amdc2363> <546F3161.1040906@myspectrum.nl> Message-ID: <20141121163059.31b19f9f@lilith> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Jeroen, On Fri, 21 Nov 2014 13:34:41 +0100, Jeroen Hofstee wrote: > >> But oh well, if it fixes a warning :-) > > I didn't claim that there is a bug in the code :-). > > > > I just get annoying when on my continuous integration script I see the > > same warning for all cross compiled boards. > > Wouldn't it be better to simply disable the -Wmaybe-uninitialized for > gcc? Disabling a warning is hiding potential dust under the carpet IMO, and the only justification I see as acceptable for doing so is when leaving the warning enabled would cause an obnoxiously high number of false positives. > Regards, > Jeroen Amicalement, -- Albert.