From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] fix: tools: kwbimage.c: Initialize headersz to suppress warning
Date: Fri, 21 Nov 2014 22:52:27 +0100 [thread overview]
Message-ID: <20141121225227.6aeb5d3d@lilith> (raw)
In-Reply-To: <1416558163-23614-1-git-send-email-l.majewski@samsung.com>
Hello Lukasz,
On Fri, 21 Nov 2014 09:22:43 +0100, Lukasz Majewski
<l.majewski@samsung.com> wrote:
> When building with my toolchain (4.8.2):
> CROSS_COMPILE=/home/lukma/work/ptxdist/toolchains/arm/OSELAS.Toolchain-2013.12.0/arm-v7a-linux-gnueabi/gcc-4.8.2-glibc-2.18-binutils-2.24-kernel-3.12-sanitized/bin/arm-v7a-linux-gnueabi-
>
> I see following WARNING:
> tools/kwbimage.c: In function "kwbimage_set_header":
> tools/kwbimage.c:803:8: warning: "headersz" may be used uninitialized in this function [-Wmaybe-uninitialized]
> memcpy(ptr, image, headersz);
> ^
> This fix aims to suppress it.
>
> Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
> ---
> tools/kwbimage.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/kwbimage.c b/tools/kwbimage.c
> index c50f2e2..2c302e5 100644
> --- a/tools/kwbimage.c
> +++ b/tools/kwbimage.c
> @@ -728,7 +728,7 @@ static void kwbimage_set_header(void *ptr, struct stat *sbuf, int ifd,
> FILE *fcfg;
> void *image = NULL;
> int version;
> - size_t headersz;
> + size_t headersz = 0;
> uint32_t checksum;
> int ret;
> int size;
> --
> 2.0.0.rc2
As I was wondering whether there could not be a better way to prevent
the warning, I tried to reproduce the case. I've tried gcc 4.8.3 as well
as 4.9.1 and gcc 4.7.4, and none of them emits the warning above.
Lukasz, where can I find the toolchain that you are using and which
emits the warning?
Amicalement,
--
Albert.
next prev parent reply other threads:[~2014-11-21 21:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-21 8:22 [U-Boot] [PATCH] fix: tools: kwbimage.c: Initialize headersz to suppress warning Lukasz Majewski
2014-11-21 8:35 ` Thomas Petazzoni
2014-11-21 9:20 ` Lukasz Majewski
2014-11-21 12:34 ` Jeroen Hofstee
2014-11-21 15:30 ` Albert ARIBAUD
2014-11-21 19:34 ` Jeroen Hofstee
2014-11-22 6:56 ` Lukasz Majewski
2014-11-22 12:17 ` Albert ARIBAUD
2014-11-23 17:38 ` Lukasz Majewski
2014-11-24 8:39 ` Lukasz Majewski
2014-11-24 18:00 ` Albert ARIBAUD
2014-12-08 11:40 ` Lukasz Majewski
2014-11-24 8:52 ` Guillaume Gardet
2014-11-21 9:54 ` Stefan Roese
2014-11-21 10:14 ` Heiko Schocher
2014-11-21 21:52 ` Albert ARIBAUD [this message]
2015-01-10 19:10 ` [U-Boot] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141121225227.6aeb5d3d@lilith \
--to=albert.u.boot@aribaud.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox