From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, 03/10] mtd: nand: s3c: Fix data type width in debug()
Date: Wed, 26 Nov 2014 20:06:14 -0600 [thread overview]
Message-ID: <20141127020614.GA26440@home.buserror.net> (raw)
In-Reply-To: <1413045778-5690-3-git-send-email-marex@denx.de>
On Sat, Oct 11, 2014 at 06:42:51PM +0200, Marek Vasut wrote:
> Printing u32 with %02x is just a bad idea, fix it.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Kyungmin Park <kyungmin.park@samsung.com>
> Cc: Lukasz Majewski <l.majewski@samsung.com>
> Cc: Minkyu Kang <mk7.kang@samsung.com>
> Cc: Scott Wood <scottwood@freescale.com>
> Cc: Vladimir Zapolskiy <vz@mleia.com>
> ---
> drivers/mtd/nand/s3c2410_nand.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/s3c2410_nand.c b/drivers/mtd/nand/s3c2410_nand.c
> index db87d07..399f2bc 100644
> --- a/drivers/mtd/nand/s3c2410_nand.c
> +++ b/drivers/mtd/nand/s3c2410_nand.c
> @@ -43,7 +43,7 @@ static void s3c2410_hwcontrol(struct mtd_info *mtd, int cmd, unsigned int ctrl)
> struct nand_chip *chip = mtd->priv;
> struct s3c2410_nand *nand = s3c2410_get_base_nand();
>
> - debug("hwcontrol(): 0x%02x 0x%02x\n", cmd, ctrl);
> + debug("hwcontrol(): 0x%02x 0x%08x\n", cmd & 0xff, ctrl);
What is the purpose of forcing extra zeroes in ctrl all the time? Why is
the lack of such ugliness "just a bad idea"?
Also, the masking of cmd is an unexplained change.
-Scott
next prev parent reply other threads:[~2014-11-27 2:06 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-11 16:42 [U-Boot] [PATCH 01/10] video: Add S3C24xx framebuffer support Marek Vasut
2014-10-11 16:42 ` [U-Boot] [PATCH 02/10] arm: s3c24xx: Fix incorrect CONFIG_SYS_S3C2410_NAND_HWECC name Marek Vasut
2014-11-27 2:03 ` [U-Boot] [U-Boot, " Scott Wood
2015-05-02 0:46 ` Marek Vasut
2015-05-02 1:11 ` Scott Wood
2015-05-02 1:18 ` Marek Vasut
2015-05-02 3:41 ` Scott Wood
2014-10-11 16:42 ` [U-Boot] [PATCH 03/10] mtd: nand: s3c: Fix data type width in debug() Marek Vasut
2014-11-27 2:06 ` Scott Wood [this message]
2014-10-11 16:42 ` [U-Boot] [PATCH 04/10] mtd: nand: s3c: Unify the register definition and naming Marek Vasut
2014-10-11 16:42 ` [U-Boot] [PATCH 05/10] mtd: nand: s3c: Add S3C2440 specifics Marek Vasut
2014-11-27 2:20 ` [U-Boot] [U-Boot,05/10] " Scott Wood
2015-05-02 0:48 ` Marek Vasut
2015-05-02 1:05 ` Scott Wood
2014-10-11 16:42 ` [U-Boot] [PATCH 06/10] mtd: nand: s3c: Add S3C2440 buffer reading Marek Vasut
2014-10-11 16:42 ` [U-Boot] [PATCH 07/10] mtd: nand: s3c: Add missing correction and select_chip functions Marek Vasut
2014-10-28 22:45 ` Scott Wood
2016-01-14 1:41 ` Marek Vasut
2016-02-12 23:18 ` Scott Wood
2016-02-19 17:53 ` Marek Vasut
2016-02-19 17:54 ` Scott Wood
2014-10-11 16:42 ` [U-Boot] [PATCH 08/10] i2c: s3c: Implant support for S3C2440 Marek Vasut
2015-05-02 1:12 ` Marek Vasut
2015-05-06 8:02 ` Minkyu Kang
2014-10-11 16:42 ` [U-Boot] [PATCH 09/10] gpio: s3c: Fix the GPIO driver Marek Vasut
2015-05-02 1:12 ` Marek Vasut
2015-05-06 8:02 ` Minkyu Kang
2014-10-11 16:42 ` [U-Boot] [PATCH 10/10] net: smc911x: Keep MAC programmed Marek Vasut
2014-11-10 21:29 ` [U-Boot] [U-Boot,10/10] " Tom Rini
2014-10-16 9:28 ` [U-Boot] [PATCH 01/10] video: Add S3C24xx framebuffer support Anatolij Gustschin
2015-05-02 1:12 ` Marek Vasut
2016-02-19 18:02 ` Anatolij Gustschin
2016-02-19 18:37 ` Marek Vasut
2016-02-22 17:10 ` Anatolij Gustschin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141127020614.GA26440@home.buserror.net \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox