public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Masahiro Yamada <yamada.m@jp.panasonic.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 01/10] dm: i2c: Add a uclass for I2C
Date: Tue, 02 Dec 2014 13:35:51 +0900	[thread overview]
Message-ID: <20141202133550.67DF.AA925319@jp.panasonic.com> (raw)
In-Reply-To: <CAPnjgZ3Uq1Xy+jKoj7_Fk=5fbNK0dL9kH0WUV1uHPxV2uf1FWQ@mail.gmail.com>

Hi Simon,





On Mon, 1 Dec 2014 21:31:29 -0700
Simon Glass <sjg@chromium.org> wrote:

> +Heiko - are you OK with the new msg-based approach?

This approach looks much better to me.




> >> +     .name           = "i2c_generic_drv",
> >> +     .id             = UCLASS_I2C_GENERIC,
> >> +};
> >
> >
> > Can we move "i2c_generic" to a different file?
> > maybe, drivers/i2c/i2c-generic.c or drivers/i2c/i2c-generic-chip.c ?
> >
> > UCLASS_DRIVER(i2c) is a bus, whereas UCLASS_DRIVER(i2c_generic) is a chip.
> >
> > Mixing up a bus and a chip-device together in the same file
> > looks confusing to me.


I take back this comment.

I thought it again, and
"i2c_generic" is short enough to be included in i2c-uclass.c.
I am fine with it as is.


Best Regards
Masahiro Yamada

  reply	other threads:[~2014-12-02  4:35 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-24 18:57 [U-Boot] [PATCH v3 0/10] dm: Add I2C support and convert sandbox, tegra Simon Glass
2014-11-24 18:57 ` [U-Boot] [PATCH v3 01/10] dm: i2c: Add a uclass for I2C Simon Glass
2014-11-28  4:47   ` Simon Glass
2014-12-01  9:02     ` Masahiro Yamada
2014-12-01 11:47   ` Masahiro Yamada
2014-12-02  4:31     ` Simon Glass
2014-12-02  4:35       ` Masahiro Yamada [this message]
2014-12-02  6:29       ` Heiko Schocher
2014-12-02 17:42         ` Simon Glass
2014-12-03 15:12     ` Simon Glass
2014-12-03 13:24   ` Masahiro Yamada
2014-12-03 15:13     ` Simon Glass
2014-12-03 16:02       ` Masahiro YAMADA
2014-12-04  2:01   ` Masahiro Yamada
2014-12-04  2:32     ` Simon Glass
2014-12-04  7:24       ` Masahiro Yamada
2014-12-04 12:23         ` Simon Glass
2014-12-04  2:36     ` Simon Glass
2014-12-04  7:27       ` Masahiro Yamada
2014-12-04 12:27         ` Simon Glass
2014-12-04  4:36   ` Masahiro Yamada
2014-12-04  5:07     ` Simon Glass
2014-11-24 18:57 ` [U-Boot] [PATCH v3 02/10] dm: i2c: Implement driver model support in the i2c command Simon Glass
2014-11-24 18:57 ` [U-Boot] [PATCH v3 03/10] dm: i2c: Add I2C emulation driver for sandbox Simon Glass
2014-11-24 18:57 ` [U-Boot] [PATCH v3 04/10] dm: i2c: Add a sandbox I2C driver Simon Glass
2014-11-24 18:57 ` [U-Boot] [PATCH v3 05/10] dm: i2c: Add an I2C EEPROM simulator Simon Glass
2014-11-24 18:57 ` [U-Boot] [PATCH v3 06/10] dm: i2c: config: Enable I2C for sandbox using driver model Simon Glass
2014-11-24 18:57 ` [U-Boot] [PATCH v3 07/10] dm: i2c: dts: Add an I2C bus for sandbox Simon Glass
2014-11-24 18:57 ` [U-Boot] [PATCH v3 08/10] dm: Add a simple EEPROM driver Simon Glass
2014-12-01 11:48   ` Masahiro Yamada
2014-12-03 15:18     ` Simon Glass
2014-12-03 16:03       ` Masahiro YAMADA
2014-12-03 16:16       ` Przemyslaw Marczak
2014-11-24 18:57 ` [U-Boot] [PATCH v3 09/10] dm: i2c: Add tests for I2C Simon Glass
2014-11-24 18:57 ` [U-Boot] [PATCH v3 10/10] dm: i2c: tegra: Convert to driver model Simon Glass
2014-12-01 11:53   ` Masahiro Yamada
2014-12-03 13:30   ` Masahiro Yamada
2014-12-03 15:23     ` Simon Glass
2014-12-03 15:52       ` Masahiro YAMADA
2014-12-03 16:37         ` Simon Glass
2014-12-03 16:13 ` [U-Boot] [PATCH v3 0/10] dm: Add I2C support and convert sandbox, tegra Przemyslaw Marczak
2014-12-04  2:00   ` Simon Glass
2014-12-05 13:09     ` Przemyslaw Marczak
2014-12-05 17:47       ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141202133550.67DF.AA925319@jp.panasonic.com \
    --to=yamada.m@jp.panasonic.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox