* [U-Boot] [PATCH] get_maintainer.pl: fix source tree detection
@ 2014-11-16 19:30 Daniel Schwierzeck
2014-11-17 7:26 ` Simon Glass
2014-12-08 21:41 ` [U-Boot] " Tom Rini
0 siblings, 2 replies; 4+ messages in thread
From: Daniel Schwierzeck @ 2014-11-16 19:30 UTC (permalink / raw)
To: u-boot
get_maintainer.pl always fails with following message:
./scripts/get_maintainer.pl: The current directory does not appear to be a linux kernel source tree.
This was caused by commit:
commit 548b310c68ac99a0330d8b56c797c09ff0742d1e
Author: Masahiro Yamada <yamada.m@jp.panasonic.com>
Date: Thu Oct 30 15:50:15 2014 +0900
Remove the CREDITS file
This file is not maintained these days.
We use MAINTAINERS for the maintainership of the supported boards.
For dead boards, we have some clues in doc/README.scrapyard and
also imperishable history in git-log.
Remove CREDITS from source tree detection to fix this.
Signed-off-by: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
---
scripts/get_maintainer.pl | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index 7717d68..368a20e 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -835,8 +835,7 @@ sub top_of_kernel_tree {
if ($lk_path ne "" && substr($lk_path,length($lk_path)-1,1) ne "/") {
$lk_path .= "/";
}
- if ( (-f "${lk_path}CREDITS")
- && (-f "${lk_path}Kbuild")
+ if ( (-f "${lk_path}Kbuild")
&& (-f "${lk_path}MAINTAINERS")
&& (-f "${lk_path}Makefile")
&& (-f "${lk_path}README")
--
2.1.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] get_maintainer.pl: fix source tree detection
2014-11-16 19:30 [U-Boot] [PATCH] get_maintainer.pl: fix source tree detection Daniel Schwierzeck
@ 2014-11-17 7:26 ` Simon Glass
2014-12-04 13:34 ` Simon Glass
2014-12-08 21:41 ` [U-Boot] " Tom Rini
1 sibling, 1 reply; 4+ messages in thread
From: Simon Glass @ 2014-11-17 7:26 UTC (permalink / raw)
To: u-boot
On 16 November 2014 19:30, Daniel Schwierzeck
<daniel.schwierzeck@gmail.com> wrote:
> get_maintainer.pl always fails with following message:
> ./scripts/get_maintainer.pl: The current directory does not appear to be a linux kernel source tree.
>
> This was caused by commit:
>
> commit 548b310c68ac99a0330d8b56c797c09ff0742d1e
> Author: Masahiro Yamada <yamada.m@jp.panasonic.com>
> Date: Thu Oct 30 15:50:15 2014 +0900
>
> Remove the CREDITS file
>
> This file is not maintained these days.
>
> We use MAINTAINERS for the maintainership of the supported boards.
> For dead boards, we have some clues in doc/README.scrapyard and
> also imperishable history in git-log.
>
> Remove CREDITS from source tree detection to fix this.
>
> Signed-off-by: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
Acked-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] get_maintainer.pl: fix source tree detection
2014-11-17 7:26 ` Simon Glass
@ 2014-12-04 13:34 ` Simon Glass
0 siblings, 0 replies; 4+ messages in thread
From: Simon Glass @ 2014-12-04 13:34 UTC (permalink / raw)
To: u-boot
+Masahiro
Hi Tom,
On 17 November 2014 at 00:26, Simon Glass <sjg@chromium.org> wrote:
> On 16 November 2014 19:30, Daniel Schwierzeck
> <daniel.schwierzeck@gmail.com> wrote:
>> get_maintainer.pl always fails with following message:
>> ./scripts/get_maintainer.pl: The current directory does not appear to be a linux kernel source tree.
>>
>> This was caused by commit:
>>
>> commit 548b310c68ac99a0330d8b56c797c09ff0742d1e
>> Author: Masahiro Yamada <yamada.m@jp.panasonic.com>
>> Date: Thu Oct 30 15:50:15 2014 +0900
>>
>> Remove the CREDITS file
>>
>> This file is not maintained these days.
>>
>> We use MAINTAINERS for the maintainership of the supported boards.
>> For dead boards, we have some clues in doc/README.scrapyard and
>> also imperishable history in git-log.
>>
>> Remove CREDITS from source tree detection to fix this.
>>
>> Signed-off-by: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
>
> Acked-by: Simon Glass <sjg@chromium.org>
Would you like me to pick this one up, or will you? It is assigned to
you in patchwork. At present the get_maintainer integration in patman
is broken.
Regards,
Simon
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] get_maintainer.pl: fix source tree detection
2014-11-16 19:30 [U-Boot] [PATCH] get_maintainer.pl: fix source tree detection Daniel Schwierzeck
2014-11-17 7:26 ` Simon Glass
@ 2014-12-08 21:41 ` Tom Rini
1 sibling, 0 replies; 4+ messages in thread
From: Tom Rini @ 2014-12-08 21:41 UTC (permalink / raw)
To: u-boot
On Sun, Nov 16, 2014 at 08:30:11PM +0100, Daniel Schwierzeck wrote:
> get_maintainer.pl always fails with following message:
> ./scripts/get_maintainer.pl: The current directory does not appear to be a linux kernel source tree.
>
> This was caused by commit:
>
> commit 548b310c68ac99a0330d8b56c797c09ff0742d1e
> Author: Masahiro Yamada <yamada.m@jp.panasonic.com>
> Date: Thu Oct 30 15:50:15 2014 +0900
>
> Remove the CREDITS file
>
> This file is not maintained these days.
>
> We use MAINTAINERS for the maintainership of the supported boards.
> For dead boards, we have some clues in doc/README.scrapyard and
> also imperishable history in git-log.
>
> Remove CREDITS from source tree detection to fix this.
>
> Signed-off-by: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
> Acked-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141208/41cccc76/attachment.pgp>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-12-08 21:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-16 19:30 [U-Boot] [PATCH] get_maintainer.pl: fix source tree detection Daniel Schwierzeck
2014-11-17 7:26 ` Simon Glass
2014-12-04 13:34 ` Simon Glass
2014-12-08 21:41 ` [U-Boot] " Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox