From: Masahiro Yamada <yamada.m@jp.panasonic.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] arm: ls102xa: Add dummy gpio.h to enable CONFIG_OF_CONTROL
Date: Wed, 10 Dec 2014 16:50:29 +0900 [thread overview]
Message-ID: <20141210165029.02DC.AA925319@jp.panasonic.com> (raw)
In-Reply-To: <1418192223-3899-1-git-send-email-ruchika.gupta@freescale.com>
On Wed, 10 Dec 2014 11:47:03 +0530
Ruchika Gupta <ruchika.gupta@freescale.com> wrote:
> If CONFIG_OF_CONTROL is enabled, lib/fdtdec.c is compiled.
> It includes <asm/gpio.h> and then <asm/gpio.h> includes
> <asm/arch/gpio.h>. As a result, all the SoCs that enable
> CONFIG_OF_CONTROL must have <asm/arch/gpio.h> even if they
> do not support GPIO.
>
> The right fix would be to split the lib/fdtdec.c to remove
> dependency on GPIO.This commit adds a dummy <asm/arch/gpio.h>
> to support OF_CONTROL for LS102x platform. This dummy header
> will be removed after FDT-GPIO stuff is fixed correctly.
>
> Signed-off-by: Ruchika Gupta <ruchika.gupta@freescale.com>
> ---
Oh, you too.
(I assume you saw my commit 630bf80ebb34.)
When I try to do something on my board,
I pretty often encounter awful code.
To fix that crap, I have to fix other crap first,
which requires me to fix other crap in advance...
My plate gets filled with a bunch of issues soon.
I am getting sick of this project.
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2014-12-10 7:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-10 6:17 [U-Boot] [PATCH 1/2] arm: ls102xa: Add dummy gpio.h to enable CONFIG_OF_CONTROL Ruchika Gupta
2014-12-10 7:50 ` Masahiro Yamada [this message]
2014-12-15 14:40 ` Simon Glass
2015-01-24 15:01 ` York Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141210165029.02DC.AA925319@jp.panasonic.com \
--to=yamada.m@jp.panasonic.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox