From: Masahiro Yamada <yamada.m@jp.panasonic.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v5 04/11] dm: i2c: Add a sandbox I2C driver
Date: Wed, 10 Dec 2014 22:33:06 +0900 [thread overview]
Message-ID: <20141210223306.030F.AA925319@jp.panasonic.com> (raw)
In-Reply-To: <1417793534-31642-5-git-send-email-sjg@chromium.org>
Simon,
I forgot to mention a minor issue.
On Fri, 5 Dec 2014 08:32:07 -0700
Simon Glass <sjg@chromium.org> wrote:
> +static int get_emul(struct udevice *bus, uint chip_addr, struct udevice **devp,
> + struct dm_i2c_ops **opsp)
> +{
> + const void *blob = gd->fdt_blob;
> + struct dm_i2c_chip *priv;
> + struct udevice *dev;
> + int ret;
> +
> + *devp = NULL;
> + *opsp = NULL;
> + ret = i2c_get_chip(bus, chip_addr, &dev);
> + if (ret)
> + return ret;
> + priv = dev_get_parentdata(dev);
> + if (!priv->emul) {
> + int node;
> +
> + debug("Scanning i2c bus '%s' for devices\n", dev->name);
> + for (node = fdt_first_subnode(blob, dev->of_offset);
> + node >= 0;
> + node = fdt_next_subnode(blob, node)) {
Can you fix the indent here?
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2014-12-10 13:33 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-05 15:32 [U-Boot] [PATCH v5 0/11] dm: Add I2C support and convert sandbox, tegra Simon Glass
2014-12-05 15:32 ` [U-Boot] [PATCH v5 01/11] dm: i2c: Add a uclass for I2C Simon Glass
2014-12-09 5:31 ` Simon Glass
2014-12-09 5:37 ` Masahiro Yamada
2014-12-09 6:17 ` Heiko Schocher
2014-12-09 13:54 ` Simon Glass
2014-12-10 13:23 ` Masahiro Yamada
2014-12-05 15:32 ` [U-Boot] [PATCH v5 02/11] dm: i2c: Implement driver model support in the i2c command Simon Glass
2014-12-10 13:24 ` Masahiro Yamada
2014-12-05 15:32 ` [U-Boot] [PATCH v5 03/11] dm: i2c: Add I2C emulation driver for sandbox Simon Glass
2014-12-10 13:29 ` Masahiro Yamada
2014-12-05 15:32 ` [U-Boot] [PATCH v5 04/11] dm: i2c: Add a sandbox I2C driver Simon Glass
2014-12-10 13:19 ` Masahiro Yamada
2014-12-10 15:32 ` Simon Glass
2014-12-10 13:33 ` Masahiro Yamada [this message]
2014-12-05 15:32 ` [U-Boot] [PATCH v5 05/11] dm: i2c: Add an I2C EEPROM simulator Simon Glass
2014-12-10 13:19 ` Masahiro Yamada
2014-12-10 18:00 ` Simon Glass
2014-12-05 15:32 ` [U-Boot] [PATCH v5 06/11] dm: i2c: config: Enable I2C for sandbox using driver model Simon Glass
2014-12-05 15:32 ` [U-Boot] [PATCH v5 07/11] dm: i2c: dts: Add an I2C bus for sandbox Simon Glass
2014-12-10 13:27 ` Masahiro Yamada
2014-12-05 15:32 ` [U-Boot] [PATCH v5 08/11] dm: Add a simple EEPROM driver Simon Glass
2014-12-10 13:29 ` Masahiro Yamada
2014-12-05 15:32 ` [U-Boot] [PATCH v5 09/11] dm: i2c: Add tests for I2C Simon Glass
2014-12-05 15:32 ` [U-Boot] [PATCH v5 10/11] dm: device: Add newline to debug() messages Simon Glass
2014-12-05 15:32 ` [U-Boot] [PATCH v5 11/11] dm: i2c: tegra: Convert to driver model Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141210223306.030F.AA925319@jp.panasonic.com \
--to=yamada.m@jp.panasonic.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox