public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V4 2/3] usb: eth: add ASIX AX88179 DRIVER
Date: Wed, 17 Dec 2014 17:00:07 +0100	[thread overview]
Message-ID: <201412171700.07190.marex@denx.de> (raw)
In-Reply-To: <54917835.3090103@cit-ec.uni-bielefeld.de>

On Wednesday, December 17, 2014 at 01:33:57 PM, Ren? Griessl wrote:
> > Is there a reason you can't implement write_hwaddr() so that it will
> > behave like other NICs (u-boot is the highest priority source of the
> > MAC address).
> 
> The AX88179 uses an external flash to store the MAC address. So for my
> application I do not want the user to be able to change it, since it is
> a unique ID inside the server cluster.
> I could add it as compiler option. Maybe it is even better to implement
> my behavior as option, since it differs from standard.
> I think it will be finished mid of january, so if it is OK for you in a
> separate patch.

Joe, can you just pick the patch as is and wait for subsequent patch to improve 
the driver? My understanding is that the driver is operating correctly and 
pulling the MAC from an integrated EEPROM, which is fine. If you want to allow
overriding this MAC using the $ethaddr, this is only an improvement and can be
added later. This would improve our hardware support and avoid blocking the 
driver further.

What do you think please ?

Best regards,
Marek Vasut

  reply	other threads:[~2014-12-17 16:00 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-07 15:53 [U-Boot] [PATCH V4 1/3] usb: eth: fix Makefile Rene Griessl
2014-11-07 15:53 ` [U-Boot] [PATCH V4 2/3] usb: eth: add ASIX AX88179 DRIVER Rene Griessl
2014-11-08 11:31   ` Marek Vasut
2014-12-12 11:04     ` René Griessl
2014-12-15 18:50   ` Joe Hershberger
2014-12-17 12:33     ` René Griessl
2014-12-17 16:00       ` Marek Vasut [this message]
2014-12-18  6:53         ` Joe Hershberger
2014-12-18 11:17           ` Marek Vasut
2014-12-18 20:07             ` Joe Hershberger
2014-12-21 12:55               ` Marek Vasut
2014-12-17 17:14       ` Joe Hershberger
2014-12-17 17:15   ` Joe Hershberger
2014-11-07 15:53 ` [U-Boot] [PATCH V4 3/3] usb: eth: enable AX88179 DRIVER for ARNDALE 5250 Rene Griessl
2014-11-07 21:04 ` [U-Boot] [PATCH V4 1/3] usb: eth: fix Makefile Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201412171700.07190.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox