From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Thu, 18 Dec 2014 12:16:06 +0100
Subject: [U-Boot] Regarding patch:
	http://patchwork.ozlabs.org/patch/373593/
In-Reply-To: <BL2PR03MB161DE5448D4F4B4C8635AB6E06A0@BL2PR03MB161.namprd03.prod.outlook.com>
References: <BL2PR03MB161DE5448D4F4B4C8635AB6E06A0@BL2PR03MB161.namprd03.prod.outlook.com>
Message-ID: <201412181216.06913.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Thursday, December 18, 2014 at 09:32:56 AM, Ramneek Mehresh wrote:
> Hi Marex,
> 
> Following u-boot patch is pending for your review for some time. Please let
> me know if you have any concerns. fsl/usb: Add USB XHCI support:
> http://patchwork.ozlabs.org/patch/373593/

I missed the patch completely, sorry. Next time, please keep me on CC when 
submitting the patches, that helps a lot.

As for the board_usb_init, you can drop the inline and the __board_usb_init()
and do:

__weak int board_usb_init(int index, enum usb_init_type init)
{
	return 0;
}

The static void fsl_xhci_core_exit(struct fsl_xhci *fsl_xhci) must shut down
the controller, which I don't see happening. Why?

Thanks!

Best regards,
Marek Vasut