From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Tue, 30 Dec 2014 16:34:02 +0100 Subject: [U-Boot] [PATCH 1/8] imx: i2c: Zap unnecessary malloc() calls In-Reply-To: <54A2A9F7.7000007@denx.de> References: <1418735363-5851-1-git-send-email-marex@denx.de> <54A2A9F7.7000007@denx.de> Message-ID: <201412301634.02793.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tuesday, December 30, 2014 at 02:34:47 PM, Stefano Babic wrote: > On 16/12/2014 14:09, Marek Vasut wrote: > > The malloc() calls are unnecessary, just allocate the stuff on stack. > > While at it, reorder the code a little, so that only one variable is > > used for the text, use snprintf() instead of sprintf() and use %01d > > as a formatting string to avoid any possible overflows. > > > > Signed-off-by: Marek Vasut > > Cc: Igor Grinberg > > Cc: Nikita Kiryanov > > Cc: Sean Cross > > Cc: Simon Glass > > Cc: Stefano Babic > > Cc: Tim Harvey > > --- > > Applied to u-boot-imx, thanks ! Hey! hope you had a nice holiday :) You might want to apply 2/8 and 3/8 to current codebase and send it to Tom, since they fix real problem and the board doesn't boot without this. I should have separated them out, sorry. Best regards, Marek Vasut