From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Thu, 8 Jan 2015 00:31:41 +0100 Subject: [U-Boot] [PATCH] usb: gadget: pxa25x_udc: fix use-before-initialized bug In-Reply-To: <1420655032-14097-1-git-send-email-Nable.MainInbox@googlemail.com> References: <1420655032-14097-1-git-send-email-Nable.MainInbox@googlemail.com> Message-ID: <201501080031.41107.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wednesday, January 07, 2015 at 07:23:52 PM, Nable wrote: > Fix use-before-initialized bug in pxa25x_udc driver. > > Function usb_gadget_register_driver calls udc_disable, > and udc_disable calls pullup_off that uses dev->mach->udc_command. > But dev->mach is initialized in usb_gadget_register_driver after > calling udc_disable. This patch fixes the order of initialization. > > Signed-off-by: Nable Hi! Can you please fix From: and Signed-off-by: fields so that they reflect a real person (you) ? Otherwise I'm happy you sent the fix and I'll pick the fixed version. Thanks! Best regards, Marek Vasut