From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] usb: eth: asix88179: add ability to modify MAC address
Date: Mon, 12 Jan 2015 18:37:54 +0100 [thread overview]
Message-ID: <201501121837.54843.marex@denx.de> (raw)
In-Reply-To: <54B3FF4F.4010507@cit-ec.uni-bielefeld.de>
On Monday, January 12, 2015 at 06:07:27 PM, Ren? Griessl wrote:
> Am 12.01.2015 um 17:54 schrieb Marek Vasut:
> > On Monday, January 12, 2015 at 05:51:16 PM, Rene Griessl wrote:
> >> This patch enables U-Boot to modify the MAC address of the AX88179.
> >> Tested on RECS5250 (similar to Arndale5250)
> >>
> >> Signed-off-by: Rene Griessl <rgriessl@cit-ec.uni-bielefeld.de>
> >> ---
> >>
> >> Changes for v2:
> >> - removed memcpy
> >
> > Hi!
> >
> > what was the reason for the memcpy() in the first place please ?
>
> I copied the function from the asix.c driver. There it is needed for the
> cache aligned buffer.
> But in this case the alignment is already implemented in the write
> function. So you were right, it is not needed here!
OK, thanks!
Applied to u-boot-usb/next , thanks!
Best regards,
Marek Vasut
next prev parent reply other threads:[~2015-01-12 17:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-12 16:51 [U-Boot] [PATCH v2] usb: eth: asix88179: add ability to modify MAC address Rene Griessl
2015-01-12 16:54 ` Marek Vasut
2015-01-12 17:07 ` René Griessl
2015-01-12 17:37 ` Marek Vasut [this message]
2015-01-12 18:04 ` Joe Hershberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201501121837.54843.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox