public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] net/designware: add error message on DMA reset timeout
Date: Tue, 13 Jan 2015 09:53:46 -0500	[thread overview]
Message-ID: <20150113145346.GA10826@bill-the-cat> (raw)
In-Reply-To: <1421158224-11910-1-git-send-email-abrodkin@synopsys.com>

On Tue, Jan 13, 2015 at 05:10:24PM +0300, Alexey Brodkin wrote:

> If for some reason DMA module fails to reset user oserves only this:
> --->---
> # dhcp
> Trying dwmac.e0018000
> FAIL
> --->---
> 
> This message makes not much sense.
> With proposed change error message will be more helpful:
> --->---
> # dhcp
> Trying dwmac.e0018000
> DMA reset timeout
> FAIL
> --->---
> 
> For example user may do power toggle to recover board functionality.
> 
> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> Cc: Chin Liang See <clsee@altera.com>
> Cc: Dinh Nguyen <dinguyen@altera.com>
> Cc: Albert Aribaud <albert.u.boot@aribaud.net>
> Cc: Tom Rini <trini@ti.com>
> Cc: Wolfgang Denk <wd@denx.de>
> Cc: Pavel Machek <pavel@denx.de>
> Cc: Joe Hershberger <joe.hershberger@gmail.com>
> Cc: Ian Campbell <ijc@hellion.org.uk>
> Cc: Marek Vasut <marex@denx.de>

Reviewed-by: Tom Rini <trini@ti.com>

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150113/5a2a1c49/attachment.pgp>

  reply	other threads:[~2015-01-13 14:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-13 14:10 [U-Boot] [PATCH] net/designware: add error message on DMA reset timeout Alexey Brodkin
2015-01-13 14:53 ` Tom Rini [this message]
2015-01-16 21:16 ` Pavel Machek
     [not found]   ` <1422601834.4846.2.camel@synopsys.com>
2015-01-30 10:04     ` Marek Vasut
2015-01-30 16:19       ` Joe Hershberger
2015-01-30 20:58 ` Joe Hershberger
2015-01-30 21:57 ` Joe Hershberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150113145346.GA10826@bill-the-cat \
    --to=trini@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox