From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Thu, 15 Jan 2015 00:58:58 +0100
Subject: [U-Boot] [PATCHv1 15/22] arm: socfpga: spl: add
	relocate_stack_to_sdram to lowlevel_init.S
In-Reply-To: <1421253662-27222-16-git-send-email-dinguyen@opensource.altera.com>
References: <1421253662-27222-1-git-send-email-dinguyen@opensource.altera.com>
	<1421253662-27222-16-git-send-email-dinguyen@opensource.altera.com>
Message-ID: <201501150058.58198.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Wednesday, January 14, 2015 at 05:40:55 PM, dinguyen at opensource.altera.com 
wrote:
> From: Dinh Nguyen <dinguyen@opensource.altera.com>
> 
> Add a function to relocate the stack from OCRAM to SDRAM.

Hi,

is this functionality really needed ? There's like 128 KiB of OCRAM on SoCFPGA,
which should be plenty, right? If moving the stack to SDRAM is really needed, 
then you might want to use the common stack relocation code (see relocate_code() 
function). Also, you should thoroughly describe the reason in the commit 
message, in this case it's really important.

Best regards,
Marek Vasut