From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pali =?utf-8?q?Roh=C3=A1r?= Date: Thu, 15 Jan 2015 09:49:31 +0100 Subject: [U-Boot] [PATCH] Nokia RX-51: Do not call secure PPA routine on non secure devices In-Reply-To: <54AEFC4E.6040205@gmail.com> References: <1420708300-16435-1-git-send-email-pali.rohar@gmail.com> <54AEFC4E.6040205@gmail.com> Message-ID: <201501150949.31292@pali> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Yes, and it is working (linux kernel was booted without problem). On Thursday 08 January 2015 22:53:18 Georges Savoundararadj wrote: > Hi Pali Roh?r, > > Have you tested this patch on a secure device (as the nokia > n900)? > > Regards, > > Georges > > Le 08/01/2015 10:11, Pali Roh?r a ?crit : > > Since commit 41623c91b09a0c865fab41acdaff30f060f29ad6 u-boot > > running in qemu is crashing in function > > do_omap3_emu_romcode_call(). RX-51 board uses this function > > for Cortex-A8 errata 430973 workaround (Set IBE bit in ACR) > > which is needed only on real secure device and not in qemu. > > > > This board patch just disable calling secure PPA routine on > > non secure devices. Qemu implements GP device and with this > > patch u-boot is working in qemu again. > > > > Signed-off-by: Pali Roh?r > > --- > > > > board/nokia/rx51/rx51.c | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/board/nokia/rx51/rx51.c > > b/board/nokia/rx51/rx51.c index b6b8ad6..08fcaf2 100644 > > --- a/board/nokia/rx51/rx51.c > > +++ b/board/nokia/rx51/rx51.c > > @@ -422,8 +422,12 @@ int misc_init_r(void) > > > > /* > > > > * Cortex-A8(r1p0..r1p2) errata 430973 workaround > > * Set IBE bit in Auxiliary Control Register > > > > + * > > + * Call this routine only on real secure device > > + * Qemu does not implement secure PPA and crash > > > > */ > > > > - omap3_update_aux_cr_secure_rx51(1 << 6, 0); > > + if (get_device_type() == HS_DEVICE) > > + omap3_update_aux_cr_secure_rx51(1 << 6, 0); > > > > return 0; > > > > } -- Pali Roh?r pali.rohar at gmail.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 198 bytes Desc: This is a digitally signed message part. URL: