[U-Boot] [PATCHv1 01/22] arm: socfpga: spl: Add main sdram code

Pavel Machek
2015-01-16T19:04:20Z

Hi!

> > +void wait_di_buffer(void)
> > +{
> > + if (debug_data->di_report.cur_samples == NUM_DI_SAMPLE) {
> > + debug_data->di_report.flags |= DI_REPORT_FLAGS_READY;
> > + while (debug_data->di_report.cur_samples != 0)
> > + ;
>
> Please get rid of such endless loops, since the platform might get stuck forever
> in them.

What would you propose in case of timeout? Message on serial console
and reboot?

Endless loop should trigger watchdog, anyway, no?

Pavel

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html