[U-Boot] [PATCHv1 15/22] arm: socfpga: spl: add relocate_stack_to_sdram to lowlevel_init.S

Marek Vasut
2015-01-15T22:00:46Z

On Thursday, January 15, 2015 at 08:19:15 PM, Dinh Nguyen wrote:
> Hi Marek,

Hi Dinh,

> On 01/14/2015 05:58 PM, Marek Vasut wrote:
> > On Wednesday, January 14, 2015 at 05:40:55 PM,
> > dinguyen at opensource.altera.com
> >
> > wrote:
> >> From: Dinh Nguyen <dinguyen@opensource.altera.com>
> >>
> >> Add a function to relocate the stack from OCRAM to SDRAM.
> >
> > Hi,
> >
> > is this functionality really needed ? There's like 128 KiB of OCRAM on
> > SoCFPGA,
>
> On cyclone5 and arria5, there is only 64KiB.

Ooops, sorry, my bad. You're right. But that is still boatload of memory,
given that the SPL will use some hundreds of bytes for the stack under
normal conditions.

> > which should be plenty, right? If moving the stack to SDRAM is really
> > needed, then you might want to use the common stack relocation code (see
> > relocate_code() function). Also, you should thoroughly describe the
> > reason in the commit message, in this case it's really important.
>
> I'll update in v2.

So uh, what's the reason for moving the stack into the SDRAM anyway please ?

Best regards,
Marek Vasut