[U-Boot] [PATCHv1 08/22] arm: socfpga: spl: Add call to timer_init

Dinh Nguyen
2015-02-04T03:58:57Z

On 1/14/15 5:45 PM, Marek Vasut wrote:
> On Wednesday, January 14, 2015 at 05:40:48 PM, dinguyen at opensource.altera.com
> wrote:
>> From: Dinh Nguyen <dinguyen@opensource.altera.com>
>>
>> Signed-off-by: Dinh Nguyen <dinguyen@opensource.altera.com>
>
> You might want to check common/spl/spl.c , which implements most of the standard
> SPL init procedure. It even includes the call to timer_init() there in
> board_init_r() . I wonder if you really need to call it here one more time.
> Do you ?
>

Your logic makes sense, but I think this timer_init() call in
spl_board_init() is needed. The reason is that we are releasing the
timer from reset in spl_board_init, and timer_init is getting called
before spl_board_init. If I take out this timer_init, the SPL doesn't
work so well.

Dinh