[U-Boot] [PATCHv1 13/22] arm: socfpga: spl: Add s_init

Dinh Nguyen
2015-02-09T16:50:34Z

On 02/07/2015 07:34 AM, Marek Vasut wrote:
> On Thursday, February 05, 2015 at 10:16:59 PM, Dinh Nguyen wrote:
>> On 01/14/2015 05:54 PM, Marek Vasut wrote:
>
> [...]
>
>>>> + /*
>>>> + * Private components security
>>>> + * U-Boot : configure private timer, global timer and cpu
>>>> + * component access as non secure for kernel stage (as required
>>>> + * by kernel)
>>>> + */
>>>> + setbits_le32(SOCFPGA_SCU_SNSAC, 0xfff);
>>>
>>> We do this in socfpga/misc.c in arch_early_init_r() already. You should
>>> consolidate this code so we don't have it twice I think.
>>
>> Yes, this can be removed.
>
> Hi! Please use whichever place you think is better.
>
>>>> +
>>>> +#endif /* CONFIG_SPL_BUILD */
>>>> +
>>>> + /* Configure the L2 controller to make SDRAM start at 0 */
>>>> + writel(0x1, (SOCFPGA_MPUL2_ADDRESS + SOCFPGA_MPUL2_ADRFLTR_START));
>>>
>>> This as well.
>>
>> This call has to stay because we want to map the SDRAM to 0x0 in the
>> SPL. The call in arch_early_init_r() is in u-boot, and thus is too late.
>
> Roger, but please remove the other invocation once the SPL is in place. OK?

Yes, I can remove it in the series?

Thanks,
Dinh