[U-Boot] [PATCHv1 01/22] arm: socfpga: spl: Add main sdram code

Marek Vasut
2015-02-24T17:48:04Z

On Monday, February 23, 2015 at 06:00:45 PM, Dinh Nguyen wrote:
> On 2/23/15 10:57 AM, Marek Vasut wrote:
> > On Monday, February 23, 2015 at 05:39:53 PM, Dinh Nguyen wrote:
> >> On 2/23/15 10:37 AM, Dinh Nguyen wrote:
> >>> On 2/15/15 5:25 PM, Pavel Machek wrote:
> >>>> Hi!
> >>>>
> >>>>> +#if ENABLE_BRINGUP_DEBUGGING
> >>>>
> >>>> Could we get rid of this for initial merge?
> >>>
> >>> Yeah, it can be removed.
> >>>
> >>>>> +static inline void reg_file_set_sub_stage(uint32_t set_sub_stage)
> >>>>> +{
> >>>>> + /* Read the current group and stage */
> >>>>> + uint32_t cur_stage_group = IORD_32DIRECT(REG_FILE_CUR_STAGE, 0);
> >>>>
> >>>> Could normal u-boot memory access macros be used here?
> >>>
> >>> I'll look..
> >>
> >> Actually, I'm reworking this whole IORD_* that uses the AVL_TO_APB to a
> >> function. This was already commented by Marek.
> >
> > If this can be switched to regular readl()/writel() stuff, then please do
> > so, since that'd be much less confusing.
>
> Yes, that is what I've done.

Thank you :) Looking forward to reviewing the V2 of the patches !

Best regards,
Marek Vasut