* [U-Boot] [PATCH] net/designware: add error message on DMA reset timeout
@ 2015-01-13 14:10 Alexey Brodkin
2015-01-13 14:53 ` Tom Rini
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Alexey Brodkin @ 2015-01-13 14:10 UTC (permalink / raw)
To: u-boot
If for some reason DMA module fails to reset user oserves only this:
--->---
# dhcp
Trying dwmac.e0018000
FAIL
--->---
This message makes not much sense.
With proposed change error message will be more helpful:
--->---
# dhcp
Trying dwmac.e0018000
DMA reset timeout
FAIL
--->---
For example user may do power toggle to recover board functionality.
Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
Cc: Chin Liang See <clsee@altera.com>
Cc: Dinh Nguyen <dinguyen@altera.com>
Cc: Albert Aribaud <albert.u.boot@aribaud.net>
Cc: Tom Rini <trini@ti.com>
Cc: Wolfgang Denk <wd@denx.de>
Cc: Pavel Machek <pavel@denx.de>
Cc: Joe Hershberger <joe.hershberger@gmail.com>
Cc: Ian Campbell <ijc@hellion.org.uk>
Cc: Marek Vasut <marex@denx.de>
---
drivers/net/designware.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/designware.c b/drivers/net/designware.c
index 9ded895..c03e935 100644
--- a/drivers/net/designware.c
+++ b/drivers/net/designware.c
@@ -236,8 +236,10 @@ static int dw_eth_init(struct eth_device *dev, bd_t *bis)
start = get_timer(0);
while (readl(&dma_p->busmode) & DMAMAC_SRST) {
- if (get_timer(start) >= CONFIG_MACRESET_TIMEOUT)
+ if (get_timer(start) >= CONFIG_MACRESET_TIMEOUT) {
+ printf("DMA reset timeout\n");
return -1;
+ }
mdelay(100);
};
--
2.1.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* [U-Boot] [PATCH] net/designware: add error message on DMA reset timeout
2015-01-13 14:10 [U-Boot] [PATCH] net/designware: add error message on DMA reset timeout Alexey Brodkin
@ 2015-01-13 14:53 ` Tom Rini
2015-01-16 21:16 ` Pavel Machek
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Tom Rini @ 2015-01-13 14:53 UTC (permalink / raw)
To: u-boot
On Tue, Jan 13, 2015 at 05:10:24PM +0300, Alexey Brodkin wrote:
> If for some reason DMA module fails to reset user oserves only this:
> --->---
> # dhcp
> Trying dwmac.e0018000
> FAIL
> --->---
>
> This message makes not much sense.
> With proposed change error message will be more helpful:
> --->---
> # dhcp
> Trying dwmac.e0018000
> DMA reset timeout
> FAIL
> --->---
>
> For example user may do power toggle to recover board functionality.
>
> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> Cc: Chin Liang See <clsee@altera.com>
> Cc: Dinh Nguyen <dinguyen@altera.com>
> Cc: Albert Aribaud <albert.u.boot@aribaud.net>
> Cc: Tom Rini <trini@ti.com>
> Cc: Wolfgang Denk <wd@denx.de>
> Cc: Pavel Machek <pavel@denx.de>
> Cc: Joe Hershberger <joe.hershberger@gmail.com>
> Cc: Ian Campbell <ijc@hellion.org.uk>
> Cc: Marek Vasut <marex@denx.de>
Reviewed-by: Tom Rini <trini@ti.com>
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150113/5a2a1c49/attachment.pgp>
^ permalink raw reply [flat|nested] 7+ messages in thread* [U-Boot] [PATCH] net/designware: add error message on DMA reset timeout
2015-01-13 14:10 [U-Boot] [PATCH] net/designware: add error message on DMA reset timeout Alexey Brodkin
2015-01-13 14:53 ` Tom Rini
@ 2015-01-16 21:16 ` Pavel Machek
[not found] ` <1422601834.4846.2.camel@synopsys.com>
2015-01-30 20:58 ` Joe Hershberger
2015-01-30 21:57 ` Joe Hershberger
3 siblings, 1 reply; 7+ messages in thread
From: Pavel Machek @ 2015-01-16 21:16 UTC (permalink / raw)
To: u-boot
On Tue 2015-01-13 17:10:24, Alexey Brodkin wrote:
> If for some reason DMA module fails to reset user oserves only this:
> --->---
> # dhcp
> Trying dwmac.e0018000
> FAIL
> --->---
>
> This message makes not much sense.
> With proposed change error message will be more helpful:
> --->---
> # dhcp
> Trying dwmac.e0018000
> DMA reset timeout
> FAIL
> --->---
>
> For example user may do power toggle to recover board functionality.
>
> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> Cc: Chin Liang See <clsee@altera.com>
> Cc: Dinh Nguyen <dinguyen@altera.com>
> Cc: Albert Aribaud <albert.u.boot@aribaud.net>
> Cc: Tom Rini <trini@ti.com>
> Cc: Wolfgang Denk <wd@denx.de>
Acked-by: Pavel Machek <pavel@denx.de>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply [flat|nested] 7+ messages in thread* [U-Boot] [PATCH] net/designware: add error message on DMA reset timeout
2015-01-13 14:10 [U-Boot] [PATCH] net/designware: add error message on DMA reset timeout Alexey Brodkin
2015-01-13 14:53 ` Tom Rini
2015-01-16 21:16 ` Pavel Machek
@ 2015-01-30 20:58 ` Joe Hershberger
2015-01-30 21:57 ` Joe Hershberger
3 siblings, 0 replies; 7+ messages in thread
From: Joe Hershberger @ 2015-01-30 20:58 UTC (permalink / raw)
To: u-boot
On Tue, Jan 13, 2015 at 8:10 AM, Alexey Brodkin <Alexey.Brodkin@synopsys.com>
wrote:
>
> If for some reason DMA module fails to reset user oserves only this:
> --->---
> # dhcp
> Trying dwmac.e0018000
> FAIL
> --->---
>
> This message makes not much sense.
> With proposed change error message will be more helpful:
> --->---
> # dhcp
> Trying dwmac.e0018000
> DMA reset timeout
> FAIL
> --->---
>
> For example user may do power toggle to recover board functionality.
>
> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> Cc: Chin Liang See <clsee@altera.com>
> Cc: Dinh Nguyen <dinguyen@altera.com>
> Cc: Albert Aribaud <albert.u.boot@aribaud.net>
> Cc: Tom Rini <trini@ti.com>
> Cc: Wolfgang Denk <wd@denx.de>
> Cc: Pavel Machek <pavel@denx.de>
> Cc: Joe Hershberger <joe.hershberger@gmail.com>
> Cc: Ian Campbell <ijc@hellion.org.uk>
> Cc: Marek Vasut <marex@denx.de>
> ---
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] net/designware: add error message on DMA reset timeout
2015-01-13 14:10 [U-Boot] [PATCH] net/designware: add error message on DMA reset timeout Alexey Brodkin
` (2 preceding siblings ...)
2015-01-30 20:58 ` Joe Hershberger
@ 2015-01-30 21:57 ` Joe Hershberger
3 siblings, 0 replies; 7+ messages in thread
From: Joe Hershberger @ 2015-01-30 21:57 UTC (permalink / raw)
To: u-boot
On Tue, Jan 13, 2015 at 8:10 AM, Alexey Brodkin <Alexey.Brodkin@synopsys.com>
wrote:
>
> If for some reason DMA module fails to reset user oserves only this:
> --->---
> # dhcp
> Trying dwmac.e0018000
> FAIL
> --->---
>
> This message makes not much sense.
> With proposed change error message will be more helpful:
> --->---
> # dhcp
> Trying dwmac.e0018000
> DMA reset timeout
> FAIL
> --->---
>
> For example user may do power toggle to recover board functionality.
>
> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> Cc: Chin Liang See <clsee@altera.com>
> Cc: Dinh Nguyen <dinguyen@altera.com>
> Cc: Albert Aribaud <albert.u.boot@aribaud.net>
> Cc: Tom Rini <trini@ti.com>
> Cc: Wolfgang Denk <wd@denx.de>
> Cc: Pavel Machek <pavel@denx.de>
> Cc: Joe Hershberger <joe.hershberger@gmail.com>
> Cc: Ian Campbell <ijc@hellion.org.uk>
> Cc: Marek Vasut <marex@denx.de>
> ---
Applied, Thanks!
-Joe
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-01-30 21:57 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-13 14:10 [U-Boot] [PATCH] net/designware: add error message on DMA reset timeout Alexey Brodkin
2015-01-13 14:53 ` Tom Rini
2015-01-16 21:16 ` Pavel Machek
[not found] ` <1422601834.4846.2.camel@synopsys.com>
2015-01-30 10:04 ` Marek Vasut
2015-01-30 16:19 ` Joe Hershberger
2015-01-30 20:58 ` Joe Hershberger
2015-01-30 21:57 ` Joe Hershberger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox